netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Joanne Koong <joannelkoong@gmail.com>, bpf@vger.kernel.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, andrii@kernel.org,
	daniel@iogearbox.net, ast@kernel.org, kafai@fb.com,
	memxor@gmail.com, toke@redhat.com, kuba@kernel.org,
	netdev@vger.kernel.org, Joanne Koong <joannelkoong@gmail.com>
Subject: Re: [PATCH bpf-next v5 1/3] bpf: Add skb dynptrs
Date: Thu, 1 Sep 2022 09:58:06 +0800	[thread overview]
Message-ID: <202209010925.Du4GHGW9-lkp@intel.com> (raw)
In-Reply-To: <20220831183224.3754305-2-joannelkoong@gmail.com>

Hi Joanne,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Joanne-Koong/Add-skb-xdp-dynptrs/20220901-024122
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: hexagon-randconfig-r045-20220831 (https://download.01.org/0day-ci/archive/20220901/202209010925.Du4GHGW9-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project c55b41d5199d2394dd6cdb8f52180d8b81d809d4)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/273adaa44c063c460e9a23123957a1864c5cc26c
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Joanne-Koong/Add-skb-xdp-dynptrs/20220901-024122
        git checkout 273adaa44c063c460e9a23123957a1864c5cc26c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from kernel/sysctl.c:35:
>> include/linux/filter.h:1540:5: warning: no previous prototype for function '__bpf_skb_load_bytes' [-Wmissing-prototypes]
   int __bpf_skb_load_bytes(const struct sk_buff *skb, u32 offset, void *to, u32 len)
       ^
   include/linux/filter.h:1540:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __bpf_skb_load_bytes(const struct sk_buff *skb, u32 offset, void *to, u32 len)
   ^
   static 
>> include/linux/filter.h:1545:5: warning: no previous prototype for function '__bpf_skb_store_bytes' [-Wmissing-prototypes]
   int __bpf_skb_store_bytes(struct sk_buff *skb, u32 offset, const void *from,
       ^
   include/linux/filter.h:1545:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __bpf_skb_store_bytes(struct sk_buff *skb, u32 offset, const void *from,
   ^
   static 
   2 warnings generated.
--
   In file included from kernel/kallsyms.c:25:
>> include/linux/filter.h:1540:5: warning: no previous prototype for function '__bpf_skb_load_bytes' [-Wmissing-prototypes]
   int __bpf_skb_load_bytes(const struct sk_buff *skb, u32 offset, void *to, u32 len)
       ^
   include/linux/filter.h:1540:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __bpf_skb_load_bytes(const struct sk_buff *skb, u32 offset, void *to, u32 len)
   ^
   static 
>> include/linux/filter.h:1545:5: warning: no previous prototype for function '__bpf_skb_store_bytes' [-Wmissing-prototypes]
   int __bpf_skb_store_bytes(struct sk_buff *skb, u32 offset, const void *from,
       ^
   include/linux/filter.h:1545:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __bpf_skb_store_bytes(struct sk_buff *skb, u32 offset, const void *from,
   ^
   static 
   kernel/kallsyms.c:570:12: warning: no previous prototype for function 'arch_get_kallsym' [-Wmissing-prototypes]
   int __weak arch_get_kallsym(unsigned int symnum, unsigned long *value,
              ^
   kernel/kallsyms.c:570:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __weak arch_get_kallsym(unsigned int symnum, unsigned long *value,
   ^
   static 
   3 warnings generated.
--
>> ld.lld: error: duplicate symbol: __bpf_skb_load_bytes
   >>> defined at filter.h:1542 (include/linux/filter.h:1542)
   >>>            sysctl.o:(__bpf_skb_load_bytes) in archive kernel/built-in.a
   >>> defined at filter.h:1542 (include/linux/filter.h:1542)
   >>>            extable.o:(.text+0x0) in archive kernel/built-in.a
--
>> ld.lld: error: duplicate symbol: __bpf_skb_store_bytes
   >>> defined at filter.h:1548 (include/linux/filter.h:1548)
   >>>            sysctl.o:(__bpf_skb_store_bytes) in archive kernel/built-in.a
   >>> defined at filter.h:1548 (include/linux/filter.h:1548)
   >>>            extable.o:(.text+0x8) in archive kernel/built-in.a
--
>> ld.lld: error: duplicate symbol: __bpf_skb_load_bytes
   >>> defined at filter.h:1542 (include/linux/filter.h:1542)
   >>>            sysctl.o:(__bpf_skb_load_bytes) in archive kernel/built-in.a
   >>> defined at filter.h:1542 (include/linux/filter.h:1542)
   >>>            kallsyms.o:(.text+0x0) in archive kernel/built-in.a
--
>> ld.lld: error: duplicate symbol: __bpf_skb_store_bytes
   >>> defined at filter.h:1548 (include/linux/filter.h:1548)
   >>>            sysctl.o:(__bpf_skb_store_bytes) in archive kernel/built-in.a
   >>> defined at filter.h:1548 (include/linux/filter.h:1548)
   >>>            kallsyms.o:(.text+0x8) in archive kernel/built-in.a

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

  parent reply	other threads:[~2022-09-01  1:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-31 18:32 [PATCH bpf-next v5 0/3] Add skb + xdp dynptrs Joanne Koong
2022-08-31 18:32 ` [PATCH bpf-next v5 1/3] bpf: Add skb dynptrs Joanne Koong
2022-09-01  1:27   ` kernel test robot
2022-09-01  1:58   ` kernel test robot [this message]
2022-09-01  3:51   ` kernel test robot
2022-09-01 19:59   ` Martin KaFai Lau
2022-09-01 21:58     ` Joanne Koong
2022-08-31 18:32 ` [PATCH bpf-next v5 2/3] bpf: Add xdp dynptrs Joanne Koong
2022-09-01  3:09   ` kernel test robot
2022-08-31 18:32 ` [PATCH bpf-next v5 3/3] selftests/bpf: tests for using dynptrs to parse skb and xdp buffers Joanne Koong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202209010925.Du4GHGW9-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=joannelkoong@gmail.com \
    --cc=kafai@fb.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kuba@kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=memxor@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).