From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>, Florian Fainelli <f.fainelli@gmail.com>
Cc: wei.fang@nxp.com, davem@davemloft.net, edumazet@google.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: fec: add pm_qos support on imx6q platform
Date: Thu, 1 Sep 2022 13:10:16 -0700 [thread overview]
Message-ID: <20220901131016.74a9a730@kernel.org> (raw)
In-Reply-To: <703b0c990f4c7b7db8496cb397fdc6dbccdc1c67.camel@redhat.com>
On Thu, 01 Sep 2022 09:17:37 +0200 Paolo Abeni wrote:
> On Tue, 2022-08-30 at 15:01 +0800, wei.fang@nxp.com wrote:
> > From: Wei Fang <wei.fang@nxp.com>
> >
> > There is a very low probability that tx timeout will occur during
> > suspend and resume stress test on imx6q platform. So we add pm_qos
> > support to prevent system from entering low level idles which may
> > affect the transmission of tx.
> >
> > Signed-off-by: Wei Fang <wei.fang@nxp.com>
>
> Since this IMHO causes a significal behavior change I suggest to target
> the net-next tree, does that fit you?
>
> Additionally, it would be great if you could provide in the changelog
> the references to the relevant platform documentation and (even rough)
> power consumption delta estimates.
It's a tricky one, we don't want older kernels to potentially hang
either.
IIRC Florian did some WoL extensions for BRCM, maybe he has the right
experience.
Florian, what would you recommend? net or net-next?
next prev parent reply other threads:[~2022-09-01 20:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 7:01 [PATCH net] net: fec: add pm_qos support on imx6q platform wei.fang
2022-09-01 2:36 ` Jakub Kicinski
2022-09-01 4:46 ` Wei Fang
2022-09-01 7:17 ` Paolo Abeni
2022-09-01 20:10 ` Jakub Kicinski [this message]
2022-09-02 2:05 ` Wei Fang
2022-09-03 4:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220901131016.74a9a730@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).