From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1D92ECAAD3 for ; Thu, 1 Sep 2022 20:10:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234853AbiIAUKY (ORCPT ); Thu, 1 Sep 2022 16:10:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231589AbiIAUKW (ORCPT ); Thu, 1 Sep 2022 16:10:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4C6F286FE; Thu, 1 Sep 2022 13:10:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 688A961C2F; Thu, 1 Sep 2022 20:10:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BE1BC433D7; Thu, 1 Sep 2022 20:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662063017; bh=rq8nBVfudyWwGfUgkKprANMLSWkU10YJR0ZDIuz8TRU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=u3Y/noazjS5GAFdYfsRFFEkZwZ8AnKI0Dc8X0WNDBxPMfrxQNS3ZYckce6u1sns8o jcI3+3RTnk0OO4rwp0F4pV7XTFYyVp8pfbWcvzNHqHoVfWszQspbrHc2/EHdpU0+re 3x5vDKUpqGsqE8Oc1lw+N8eDn/HCZfoy6AWKZDV2hf2YZKZpJx7zlwLHaAEPJqF52y 1qpRLj4TE8sk7SjVEGbXo87tuROyK1MMPTevS49CuaSVukrr7x/cawdMD3DJ5kIcc/ B4MrekhTErUK1ma1zSjdxKNvK5BMK230PhJuKZPimiXSwSdPemiwTM3G5MOEMJubb0 bO4kNpQ1BUFog== Date: Thu, 1 Sep 2022 13:10:16 -0700 From: Jakub Kicinski To: Paolo Abeni , Florian Fainelli Cc: wei.fang@nxp.com, davem@davemloft.net, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: fec: add pm_qos support on imx6q platform Message-ID: <20220901131016.74a9a730@kernel.org> In-Reply-To: <703b0c990f4c7b7db8496cb397fdc6dbccdc1c67.camel@redhat.com> References: <20220830070148.2021947-1-wei.fang@nxp.com> <703b0c990f4c7b7db8496cb397fdc6dbccdc1c67.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 01 Sep 2022 09:17:37 +0200 Paolo Abeni wrote: > On Tue, 2022-08-30 at 15:01 +0800, wei.fang@nxp.com wrote: > > From: Wei Fang > > > > There is a very low probability that tx timeout will occur during > > suspend and resume stress test on imx6q platform. So we add pm_qos > > support to prevent system from entering low level idles which may > > affect the transmission of tx. > > > > Signed-off-by: Wei Fang > > Since this IMHO causes a significal behavior change I suggest to target > the net-next tree, does that fit you? > > Additionally, it would be great if you could provide in the changelog > the references to the relevant platform documentation and (even rough) > power consumption delta estimates. It's a tricky one, we don't want older kernels to potentially hang either. IIRC Florian did some WoL extensions for BRCM, maybe he has the right experience. Florian, what would you recommend? net or net-next?