From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Claudiu Manoil" <claudiu.manoil@nxp.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"Colin Foster" <colin.foster@in-advantage.com>,
"Roopa Prabhu" <roopa@nvidia.com>,
"Nikolay Aleksandrov" <razor@blackwall.org>,
"Tobias Waldekranz" <tobias@waldekranz.com>,
"Marek Behún" <kabel@kernel.org>,
"Ansuel Smith" <ansuelsmth@gmail.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Luiz Angelo Daros de Luca" <luizluca@gmail.com>,
"Felix Fietkau" <nbd@nbd.name>, "John Crispin" <john@phrozen.org>,
"Sean Wang" <sean.wang@mediatek.com>
Subject: Re: [PATCH net-next 3/9] net: dsa: allow the DSA master to be seen and changed through rtnetlink
Date: Thu, 1 Sep 2022 13:29:04 +0000 [thread overview]
Message-ID: <20220901132903.yidpk3v4wrm4hfu4@skbuf> (raw)
In-Reply-To: <20220831205020.28fbfcc5@kernel.org>
On Wed, Aug 31, 2022 at 08:50:20PM -0700, Jakub Kicinski wrote:
> net/dsa/port.c: In function ‘dsa_port_change_master’:
> net/dsa/port.c:1414:13: warning: unused variable ‘port’ [-Wunused-variable]
> 1414 | int port = dp->index;
> | ^~~~
I did build patch by patch, but in the sea of stuff that got rebuilt
when I modified include/uapi/linux/if_link.h, I couldn't notice anything.
> I presume you had a look around what side effects setting rtnl_link_ops
> will have? Should .netns_refund be true?
I'm not quite sure what other side effects there will be. The netns_refund
property should be set to true, yes.
next prev parent reply other threads:[~2022-09-01 13:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 19:59 [PATCH net-next 0/9] DSA changes for multiple CPU ports (part 4) Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 1/9] net: introduce iterators over synced hw addresses Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 2/9] net: dsa: introduce dsa_port_get_master() Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 3/9] net: dsa: allow the DSA master to be seen and changed through rtnetlink Vladimir Oltean
2022-09-01 3:50 ` Jakub Kicinski
2022-09-01 13:29 ` Vladimir Oltean [this message]
2022-08-30 19:59 ` [PATCH net-next 4/9] net: dsa: don't keep track of admin/oper state on LAG DSA masters Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 5/9] net: dsa: suppress appending ethtool stats to " Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 6/9] net: dsa: suppress device links " Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 7/9] net: dsa: allow masters to join a LAG Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 8/9] docs: net: dsa: update information about multiple CPU ports Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 9/9] net: dsa: felix: add support for changing DSA master Vladimir Oltean
2022-09-02 10:31 ` [PATCH net-next 0/9] DSA changes for multiple CPU ports (part 4) Vladimir Oltean
2022-09-02 18:33 ` Florian Fainelli
2022-09-02 18:40 ` Vladimir Oltean
2022-09-03 2:48 ` Marek Behún
2022-09-04 15:41 ` Vladimir Oltean
2022-09-02 18:44 ` Christian Marangi
2022-09-03 2:50 ` Marek Behún
2022-09-04 19:34 ` Vladimir Oltean
2022-09-06 16:10 ` Colin Foster
2022-09-06 16:18 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220901132903.yidpk3v4wrm4hfu4@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=claudiu.manoil@nxp.com \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=john@phrozen.org \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luizluca@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=sean.wang@mediatek.com \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox