From: Stephen Hemminger <stephen@networkplumber.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
David Ahern <dsahern@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH iproute2] ip link: add sub-command to view and change DSA master
Date: Tue, 6 Sep 2022 09:55:17 -0700 [thread overview]
Message-ID: <20220906095517.4022bde6@hermes.local> (raw)
In-Reply-To: <20220906164117.7eiirl4gm6bho2ko@skbuf>
On Tue, 6 Sep 2022 16:41:17 +0000
Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
> On Tue, Sep 06, 2022 at 08:29:07AM -0700, Stephen Hemminger wrote:
> > On Sun, 4 Sep 2022 22:00:25 +0300
> > Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
> >
> > > Support the "dsa" kind of rtnl_link_ops exported by the kernel, and
> > > export reads/writes to IFLA_DSA_MASTER.
> > >
> > > Examples:
> > >
> > > $ ip link set swp0 type dsa master eth1
> > >
> > > $ ip -d link show dev swp0
> > > (...)
> > > dsa master eth0
> > >
> > > $ ip -d -j link show swp0
> > > [
> > > {
> > > "link": "eth1",
> > > "linkinfo": {
> > > "info_kind": "dsa",
> > > "info_data": {
> > > "master": "eth1"
> > > }
> > > },
> > > }
> > > ]
> > >
> > > Note that by construction and as shown in the example, the IFLA_LINK
> > > reported by a DSA user port is identical to what is reported through
> > > IFLA_DSA_MASTER. However IFLA_LINK is not writable, and overloading its
> > > meaning to make it writable would clash with other users of IFLA_LINK
> > > (vlan etc) for which writing this property does not make sense.
> > >
> > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> > > ---
> >
> > Using the term master is an unfortunate choice.
> > Although it is common practice in Linux it is not part of any
> > current standard and goes against the Linux Foundation non-inclusive
> > naming policy.
>
> Concretely, what is it that you propose?
Maybe "switch" instead of "master"?
next prev parent reply other threads:[~2022-09-06 17:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 19:00 [PATCH iproute2] ip link: add sub-command to view and change DSA master Vladimir Oltean
2022-09-06 15:29 ` Stephen Hemminger
2022-09-06 16:41 ` Vladimir Oltean
2022-09-06 16:55 ` Stephen Hemminger [this message]
2022-09-06 19:13 ` Vladimir Oltean
2022-09-06 20:05 ` Andrew Lunn
2022-09-06 20:33 ` Florian Fainelli
2022-09-06 21:17 ` Stephen Hemminger
2022-09-06 21:34 ` Florian Fainelli
2022-09-06 21:37 ` Andrew Lunn
2022-09-08 12:51 ` Vladimir Oltean
2022-09-08 14:08 ` David Ahern
2022-09-08 14:25 ` Stephen Hemminger
2022-09-08 16:11 ` Vladimir Oltean
2022-09-08 16:35 ` Florian Fainelli
2022-09-08 16:39 ` Stephen Hemminger
2022-09-09 6:09 ` Benjamin Poirier
2022-09-09 11:23 ` Vladimir Oltean
2022-09-09 15:03 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220906095517.4022bde6@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew@lunn.ch \
--cc=dsahern@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).