From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 134EBC38145 for ; Wed, 7 Sep 2022 19:38:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229990AbiIGTiI (ORCPT ); Wed, 7 Sep 2022 15:38:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229982AbiIGTiC (ORCPT ); Wed, 7 Sep 2022 15:38:02 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C89CEC1212 for ; Wed, 7 Sep 2022 12:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662579475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TGroVYrUR+FlP7enzDgAT8Dk+QrrDDFqASiVxT9Otco=; b=DbUkYSqjwtLBUKPPEXKPfLJinMAk2d0RsgFLaNBAKounUKiV4ssF4mVMqwIn3sGA69DNm1 oKmKVBYWgOJYzBvOmHKt3dbRWPz3U+mRAOBUUO/sV8iMFERycze7lbG7MWCrlvhR5bAh8U DgSEZrK2ZqT8AO+I/q2OCkVLPFTeJ0s= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-423-uYKMFSL7Oy6Wo27bsPebBQ-1; Wed, 07 Sep 2022 15:37:54 -0400 X-MC-Unique: uYKMFSL7Oy6Wo27bsPebBQ-1 Received: by mail-qt1-f199.google.com with SMTP id v5-20020ac873c5000000b003434ef0a8c7so12784588qtp.21 for ; Wed, 07 Sep 2022 12:37:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=TGroVYrUR+FlP7enzDgAT8Dk+QrrDDFqASiVxT9Otco=; b=5E1MkZkZwxBhu+jVMBcnCe+VR3xQTm0PZ6ky5UCeg/T8OjAqJEj0Xo3xyZ4lfpShnD ANyeNsXQZ47Rk0tqChOQPl6sdmHgLhMGifI//H6NAJC5E8Oj+3VmrGuDDb/Jj7reHvr4 DdsGm7lsnlrXh6jWLkGlVYXTFfWwj/fOAilnls8okPFOq71YbeFoWItxsBpDuwii/+yf Rx1bUFo4v0IwBLN/UUv48VQSABDSnhVfmAnR0/rUZ8KM7ZM+lmzq+M6oEM3UpdZLGbF4 NJjqVDJ4itJwGIyRyrZenfzxJySqfoSBzxN/A67LhriMB3MbKdrxyT9NiDwL0Ksx44DG G6ng== X-Gm-Message-State: ACgBeo3JyR0gScXYIA9Kl+/zDsoqsQ8TY8MD8B9u7YbLek0FafqHf3s+ HjCqH3SyLEp785uqY0Y9lSjZ7x1G29erin8GZLdk7m0NnT53fqsPe9F9QtcS0Sreb/X89Vpg3Tw WBeL9WJ/HP82izTv3 X-Received: by 2002:a05:622a:5cb:b0:344:551a:c804 with SMTP id d11-20020a05622a05cb00b00344551ac804mr4772407qtb.645.1662579473917; Wed, 07 Sep 2022 12:37:53 -0700 (PDT) X-Google-Smtp-Source: AA6agR6o8+b3rCTjFRlYR6CJvTMblMf0qs3ibHzjOkhWuqZnfLiHVuUvUmc7APhywpTSHy+5koL1qQ== X-Received: by 2002:a05:622a:5cb:b0:344:551a:c804 with SMTP id d11-20020a05622a05cb00b00344551ac804mr4772386qtb.645.1662579473681; Wed, 07 Sep 2022 12:37:53 -0700 (PDT) Received: from redhat.com ([45.144.113.241]) by smtp.gmail.com with ESMTPSA id c28-20020ac81e9c000000b0034454067d24sm13524561qtm.64.2022.09.07.12.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 12:37:53 -0700 (PDT) Date: Wed, 7 Sep 2022 15:37:46 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: Gavin Li , "stephen@networkplumber.org" , "davem@davemloft.net" , "jesse.brandeburg@intel.com" , "kuba@kernel.org" , "sridhar.samudrala@intel.com" , "jasowang@redhat.com" , "loseweigh@gmail.com" , "netdev@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "virtio-dev@lists.oasis-open.org" , Gavi Teitz , Xuan Zhuo , Si-Wei Liu Subject: Re: [PATCH v5 2/2] virtio-net: use mtu size as buffer length for big packets Message-ID: <20220907153727-mutt-send-email-mst@kernel.org> References: <20220907103420-mutt-send-email-mst@kernel.org> <20220907141447-mutt-send-email-mst@kernel.org> <20220907151026-mutt-send-email-mst@kernel.org> <20220907152156-mutt-send-email-mst@kernel.org> <20220907153425-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220907153425-mutt-send-email-mst@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Sep 07, 2022 at 03:36:16PM -0400, Michael S. Tsirkin wrote: > On Wed, Sep 07, 2022 at 07:27:16PM +0000, Parav Pandit wrote: > > > > > From: Michael S. Tsirkin > > > Sent: Wednesday, September 7, 2022 3:24 PM > > > > > > On Wed, Sep 07, 2022 at 07:18:06PM +0000, Parav Pandit wrote: > > > > > > > > > From: Michael S. Tsirkin > > > > > Sent: Wednesday, September 7, 2022 3:12 PM > > > > > > > > > > Because of shallow queue of 16 entries deep. > > > > > > > > > > but why is the queue just 16 entries? > > > > I explained the calculation in [1] about 16 entries. > > > > > > > > [1] > > > > > > > https://lore.kernel.org/netdev/PH0PR12MB54812EC7F4711C1EA4CAA119DC > > > 419@ > > > > PH0PR12MB5481.namprd12.prod.outlook.com/ > > > > > > > > > does the device not support indirect? > > > > > > > > > Yes, indirect feature bit is disabled on the device. > > > > > > OK that explains it. > > > > So can we proceed with v6 to contain > > (a) updated commit message and > > (b) function name change you suggested to drop _fields suffix? > > (c) replace mtu = 0 with sensibly not calling the function > when mtu is unknown. > > > And I'd like commit log to include results of perf testing > - with indirect feature on > - with mtu feature off > just to make sure nothing breaks. and if possible a larger ring. 1k? > -- > MST