From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B322FECAAD3 for ; Fri, 9 Sep 2022 06:26:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230463AbiIIG0x (ORCPT ); Fri, 9 Sep 2022 02:26:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230426AbiIIG0w (ORCPT ); Fri, 9 Sep 2022 02:26:52 -0400 Received: from mail.nfschina.com (mail.nfschina.com [124.16.136.209]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 647481269F7; Thu, 8 Sep 2022 23:26:50 -0700 (PDT) Received: from localhost (unknown [127.0.0.1]) by mail.nfschina.com (Postfix) with ESMTP id 6EDC61E80D5E; Fri, 9 Sep 2022 14:25:19 +0800 (CST) X-Virus-Scanned: amavisd-new at test.com Received: from mail.nfschina.com ([127.0.0.1]) by localhost (mail.nfschina.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qC0r7odWaN2A; Fri, 9 Sep 2022 14:25:16 +0800 (CST) Received: from localhost.localdomain (unknown [180.167.10.98]) (Authenticated sender: yuzhe@nfschina.com) by mail.nfschina.com (Postfix) with ESMTPA id 50AF21E80D06; Fri, 9 Sep 2022 14:25:16 +0800 (CST) From: Yu Zhe To: rafal@milecki.pl, bcm-kernel-feedback-list@broadcom.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, liqiong@nfschina.com, Yu Zhe Subject: [PATCH] net: broadcom: bcm4908enet: add platform_get_irq_byname error checking Date: Fri, 9 Sep 2022 14:25:45 +0800 Message-Id: <20220909062545.16696-1-yuzhe@nfschina.com> X-Mailer: git-send-email 2.11.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The platform_get_irq_byname() function returns negative error codes on error, check it. Signed-off-by: Yu Zhe --- drivers/net/ethernet/broadcom/bcm4908_enet.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bcm4908_enet.c b/drivers/net/ethernet/broadcom/bcm4908_enet.c index c131d8118489..d985056db6c2 100644 --- a/drivers/net/ethernet/broadcom/bcm4908_enet.c +++ b/drivers/net/ethernet/broadcom/bcm4908_enet.c @@ -705,6 +705,8 @@ static int bcm4908_enet_probe(struct platform_device *pdev) return netdev->irq; enet->irq_tx = platform_get_irq_byname(pdev, "tx"); + if (enet->irq_tx < 0) + return enet->irq_tx; err = dma_set_coherent_mask(dev, DMA_BIT_MASK(32)); if (err) -- 2.11.0