From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Benjamin Poirier <benjamin.poirier@gmail.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
David Ahern <dsahern@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH iproute2] ip link: add sub-command to view and change DSA master
Date: Fri, 9 Sep 2022 11:23:50 +0000 [thread overview]
Message-ID: <20220909112349.gyrqjojo6f4dhzdt@skbuf> (raw)
In-Reply-To: <YxrYrhSRayY03ahF@d3>
On Fri, Sep 09, 2022 at 03:09:50PM +0900, Benjamin Poirier wrote:
> > So are we or are we not in the clear with IFLA_DSA_MASTER and
> > "ip link set ... type dsa master ..."? What does being in the clear even
> > mean technically, and where can I find more details about the policy
> > which you just mentioned? Like is it optional or mandatory, was there
> > any public debate surrounding the motivation for flagging some words,
> > how is it enforced, are there official exceptions, etc?
>
> There are more details in
> Documentation/process/coding-style.rst, end of ยง4.
Thanks for the pointer. So it says that if DSA was introduced in 2020 or
later, a master should have probably been named a host controller or
something of that kind. Which is probably reasonable in this context.
But I don't have the time and energy at my disposal to transition DSA to
an inclusive naming convention, at least not in a way that wouldn't then
be detrimential/confusing in the short term to the user base. So I'll
keep using IFLA_DSA_MASTER, my reading of it is that it's ok.
next prev parent reply other threads:[~2022-09-09 11:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 19:00 [PATCH iproute2] ip link: add sub-command to view and change DSA master Vladimir Oltean
2022-09-06 15:29 ` Stephen Hemminger
2022-09-06 16:41 ` Vladimir Oltean
2022-09-06 16:55 ` Stephen Hemminger
2022-09-06 19:13 ` Vladimir Oltean
2022-09-06 20:05 ` Andrew Lunn
2022-09-06 20:33 ` Florian Fainelli
2022-09-06 21:17 ` Stephen Hemminger
2022-09-06 21:34 ` Florian Fainelli
2022-09-06 21:37 ` Andrew Lunn
2022-09-08 12:51 ` Vladimir Oltean
2022-09-08 14:08 ` David Ahern
2022-09-08 14:25 ` Stephen Hemminger
2022-09-08 16:11 ` Vladimir Oltean
2022-09-08 16:35 ` Florian Fainelli
2022-09-08 16:39 ` Stephen Hemminger
2022-09-09 6:09 ` Benjamin Poirier
2022-09-09 11:23 ` Vladimir Oltean [this message]
2022-09-09 15:03 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220909112349.gyrqjojo6f4dhzdt@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=benjamin.poirier@gmail.com \
--cc=dsahern@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox