From: Vladimir Oltean <olteanv@gmail.com>
To: Mattias Forsblad <mattias.forsblad@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org, Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v7 4/6] net: dsa: mv88e6xxxx: Add RMU functionality.
Date: Sun, 11 Sep 2022 16:53:20 +0300 [thread overview]
Message-ID: <20220911135320.h5nl75ajcwjiulf6@skbuf> (raw)
In-Reply-To: <0121f604-e8b9-2551-7881-c1fd64c434e2@gmail.com>
On Fri, Sep 09, 2022 at 08:37:17AM +0200, Mattias Forsblad wrote:
> >> + chip->rmu.rmu_ops->get_rmon = mv88e6xxx_rmu_stats_get;
> >> +
> >> + if (chip->info->ops->rmu_disable)
> >> + return chip->info->ops->rmu_disable(chip);
> >
> > Why is a setup function calling disable?
>
> So Vladimir Oltean commented before:
> "I think it's very important for the RMU to still start as disabled.
> You enable it dynamically when the master goes up."
This, plus the fact that mv88e6xxx_rmu_setup() already exists in the
tree, and calls chip->info->ops->rmu_disable(). It seems like that
doesn't need to change. Mattias is moving it around, and makes it seem
as if something is being changed. Maybe simple code movement could be
split into a separate change.
next prev parent reply other threads:[~2022-09-11 13:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 13:21 [PATCH net-next v7 0/6] net: dsa: qca8k, mv88e6xxx: rmon: Add RMU support Mattias Forsblad
2022-09-08 13:21 ` [PATCH net-next v7 1/6] net: dsa: mv88e6xxx: Add RMU enable for select switches Mattias Forsblad
2022-09-08 23:10 ` Andrew Lunn
2022-09-08 13:21 ` [PATCH net-next v7 2/6] net: dsa: Add convenience functions for frame handling Mattias Forsblad
2022-09-08 13:21 ` [PATCH net-next v7 3/6] net: dsa: Introduce dsa tagger data operation Mattias Forsblad
2022-09-08 13:21 ` [PATCH net-next v7 4/6] net: dsa: mv88e6xxxx: Add RMU functionality Mattias Forsblad
2022-09-09 1:36 ` Andrew Lunn
2022-09-09 6:05 ` Mattias Forsblad
2022-09-09 6:37 ` Mattias Forsblad
2022-09-11 13:53 ` Vladimir Oltean [this message]
2022-09-09 7:49 ` Mattias Forsblad
2022-09-08 13:21 ` [PATCH net-next v7 5/6] net: dsa: mv88e6xxx: rmon: Use RMU for reading RMON data Mattias Forsblad
2022-09-09 1:49 ` Andrew Lunn
2022-09-09 7:36 ` Mattias Forsblad
2022-09-08 13:21 ` [PATCH net-next v7 6/6] net: dsa: qca8k: Use new convenience functions Mattias Forsblad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220911135320.h5nl75ajcwjiulf6@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=mattias.forsblad@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox