From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72CB1C6FA83 for ; Sun, 11 Sep 2022 23:42:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229660AbiIKXmS (ORCPT ); Sun, 11 Sep 2022 19:42:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229697AbiIKXmB (ORCPT ); Sun, 11 Sep 2022 19:42:01 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 873EE26AFE for ; Sun, 11 Sep 2022 16:41:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BC7EEB80AE9 for ; Sun, 11 Sep 2022 23:41:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CDABC433C1; Sun, 11 Sep 2022 23:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662939708; bh=ygjsiyjHJ6UJ4VeCROaruWtzXOSwa/EIHkRTmiyTdq8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rSWyNUmPMTA0/u3fNfujiYmPLU6AzjMynVgm1QsxZ4qdYnDSYr3JeeCPvwp60KDfv pwXJklli3/adextFh97JrHSoXIjNP5l7lXWH7VfrpBxAo3yXrmPLeD4ePXcdPxrwml Ttm86lV3kUr6CRZ2vpns2trpokE4Q+my3LRMyk72WQv9sLKELmK7q1s/jHLtondozC WdbgBqxgMs9Jc9hsLnC74ORxTf9LHx3+267UWlxWyDMEypWPqdHgHBHd9yMMP6MBzB fqAxTjnxpXcJAnhCE8FG7O27wl0KeSDxKAlQlcfyORmlpDE94d+rhYPQrM4RtWxEw7 WOZuq7XvL/Zng== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Emeel Hakim , Raed Salem Subject: [PATCH net-next 10/10] net/mlx5e: Support MACsec offload replay window Date: Mon, 12 Sep 2022 00:40:59 +0100 Message-Id: <20220911234059.98624-11-saeed@kernel.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220911234059.98624-1-saeed@kernel.org> References: <20220911234059.98624-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Emeel Hakim Support setting replay window size for MACsec offload. Currently supported window size of 32, 64, 128 and 256 bit. Other values will be returned as invalid parameter. Reviewed-by: Raed Salem Signed-off-by: Emeel Hakim Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/en_accel/macsec.c | 46 ++++++++++++++++--- 1 file changed, 39 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c index 6f79f87b9930..166dc4e42d74 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c @@ -153,6 +153,8 @@ struct mlx5_macsec_obj_attrs { struct mlx5e_macsec_epn_state epn_state; salt_t salt; __be32 ssci; + bool replay_protect; + u32 replay_window; }; struct mlx5_aso_ctrl_param { @@ -220,6 +222,35 @@ static void mlx5e_macsec_aso_dereg_mr(struct mlx5_core_dev *mdev, struct mlx5e_m kfree(umr); } +static int macsec_set_replay_protection(struct mlx5_macsec_obj_attrs *attrs, void *aso_ctx) +{ + u8 window_sz; + + if (!attrs->replay_protect) + return 0; + + switch (attrs->replay_window) { + case 256: + window_sz = MLX5_MACSEC_ASO_REPLAY_WIN_256BIT; + break; + case 128: + window_sz = MLX5_MACSEC_ASO_REPLAY_WIN_128BIT; + break; + case 64: + window_sz = MLX5_MACSEC_ASO_REPLAY_WIN_64BIT; + break; + case 32: + window_sz = MLX5_MACSEC_ASO_REPLAY_WIN_32BIT; + break; + default: + return -EINVAL; + } + MLX5_SET(macsec_aso, aso_ctx, window_size, window_sz); + MLX5_SET(macsec_aso, aso_ctx, mode, MLX5_MACSEC_ASO_REPLAY_PROTECTION); + + return 0; +} + static int mlx5e_macsec_create_object(struct mlx5_core_dev *mdev, struct mlx5_macsec_obj_attrs *attrs, bool is_tx, @@ -253,8 +284,12 @@ static int mlx5e_macsec_create_object(struct mlx5_core_dev *mdev, salt_p = MLX5_ADDR_OF(macsec_offload_obj, obj, salt); for (i = 0; i < 3 ; i++) memcpy((u32 *)salt_p + i, &attrs->salt.bytes[4 * (2 - i)], 4); - if (!is_tx) - MLX5_SET(macsec_aso, aso_ctx, mode, MLX5_MACSEC_ASO_REPLAY_PROTECTION); + + if (!is_tx) { + err = macsec_set_replay_protection(attrs, aso_ctx); + if (err) + return err; + } } else { MLX5_SET64(macsec_offload_obj, obj, sci, (__force u64)(attrs->sci)); } @@ -343,6 +378,8 @@ static int mlx5e_macsec_init_sa(struct macsec_context *ctx, } memcpy(&obj_attrs.salt, &key->salt, sizeof(key->salt)); + obj_attrs.replay_window = ctx->secy->replay_window; + obj_attrs.replay_protect = ctx->secy->replay_protect; err = mlx5e_macsec_create_object(mdev, &obj_attrs, is_tx, &sa->macsec_obj_id); if (err) @@ -438,11 +475,6 @@ static bool mlx5e_macsec_secy_features_validate(struct macsec_context *ctx) return false; } - if (secy->replay_protect) { - netdev_err(netdev, "MACsec offload: replay protection is not supported\n"); - return false; - } - return true; } -- 2.37.3