Re: [RFC v1 net-next 6/8] net: dsa: felix: populate mac_capabilities for all ports

Russell King (Oracle)
2022-09-12T15:33:11Z

On Mon, Sep 12, 2022 at 11:41:18AM +0000, Vladimir Oltean wrote:
> On Mon, Sep 12, 2022 at 01:16:21PM +0300, Vladimir Oltean wrote:
> > > Therefore, I think you can drop this patch from your series and
> > > you won't see any functional change.
> >
> > This is true. I am also a bit surprised at Colin's choices to
> > (b) split the work he submitted such that he populates mac_capabilities
> > but does not make any use of it (not call phylink_generic_validate
> > from anywhere). We try as much as possible to not leave dead code
> > behind in the mainline tree, even if future work is intended to
> > bring it to life. I do understand that this is an RFC so the patches
> > weren't intended to be applied as is, but it is still confusing to
> > review a change which, as you've correctly pointed out, has no
> > effect to the git tree as it stands.
>
> Ah, I retract this comment; after actually looking at all the patches, I
> do see that in patch 8/8, Colin does call phylink_generic_validate().

Good point, I obviously missed that in the series.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!