From: Li Zhong <floridsleeves@gmail.com>
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org
Cc: pabeni@redhat.com, kuba@kernel.org, edumazet@google.com,
davem@davemloft.net, anthony.l.nguyen@intel.com,
jesse.brandeburg@intel.com, Li Zhong <floridsleeves@gmail.com>
Subject: [PATCH v2] drivers/net/ethernet/intel/e100: check the return value of e100_exec_cmd()
Date: Fri, 16 Sep 2022 17:10:27 -0700 [thread overview]
Message-ID: <20220917001027.3799634-1-floridsleeves@gmail.com> (raw)
Check the return value of e100_exec_cmd() which could return error code
when execution fails.
Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
drivers/net/ethernet/intel/e100.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c
index 11a884aa5082..0d133cd4d01b 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel/e100.c
@@ -1911,7 +1911,9 @@ static inline void e100_start_receiver(struct nic *nic, struct rx *rx)
/* (Re)start RU if suspended or idle and RFA is non-NULL */
if (rx->skb) {
- e100_exec_cmd(nic, ruc_start, rx->dma_addr);
+ if (e100_exec_cmd(nic, ruc_start, rx->dma_addr))
+ netif_printk(nic, tx_err, KERN_DEBUG, nic->netdev,
+ "exec ruc_start failed\n");
nic->ru_running = RU_RUNNING;
}
}
--
2.25.1
next reply other threads:[~2022-09-17 0:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 0:10 Li Zhong [this message]
2022-09-20 18:36 ` [PATCH v2] drivers/net/ethernet/intel/e100: check the return value of e100_exec_cmd() Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220917001027.3799634-1-floridsleeves@gmail.com \
--to=floridsleeves@gmail.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).