From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Luka Perkov <luka.perkov@sartura.hr>,
Robert Marko <robert.marko@sartura.hr>
Subject: Re: [PATCH net-next v4 0/5] net: ipqess: introduce Qualcomm IPQESS driver
Date: Sat, 17 Sep 2022 11:02:02 +0200 [thread overview]
Message-ID: <20220917110202.1b8562bf@fedora> (raw)
In-Reply-To: <20220917002031.f7jddzi7ppciusie@skbuf>
On Sat, 17 Sep 2022 00:20:31 +0000
Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
> On Fri, Sep 09, 2022 at 05:24:49PM +0200, Maxime Chevallier wrote:
> > The DSA out-of-band tagging is still using the skb->headroom part,
> > but there doesn't seem to be any better way for now without adding
> > fields to struct sk_buff.
>
> Are we on the same page about what is meant by "skb extensions"? See
> what is provided by CONFIG_SKB_EXTENSIONS, I did not mean it as in
> "extend struct sk_buff with new fields".
Yep, that was one of the other approaches I had in mind, and I've
submitted a series adding fields to sk_buff in the past which was
rejected (for good reasons). But indeed that comment on the cover-letter
was misleading...
Thanks,
Maxime
prev parent reply other threads:[~2022-09-17 9:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 15:24 [PATCH net-next v4 0/5] net: ipqess: introduce Qualcomm IPQESS driver Maxime Chevallier
2022-09-09 15:24 ` [PATCH net-next v4 1/5] net: ipqess: introduce the " Maxime Chevallier
2022-09-09 15:39 ` Krzysztof Kozlowski
2022-09-11 22:11 ` kernel test robot
2022-09-09 15:24 ` [PATCH net-next v4 2/5] net: dsa: add out-of-band tagging protocol Maxime Chevallier
2022-09-17 0:15 ` Vladimir Oltean
2022-09-17 9:00 ` Maxime Chevallier
2022-09-09 15:24 ` [PATCH net-next v4 3/5] net: ipqess: Add out-of-band DSA tagging support Maxime Chevallier
2022-09-09 15:24 ` [PATCH net-next v4 4/5] net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet controller Maxime Chevallier
2022-09-09 15:35 ` Krzysztof Kozlowski
2022-09-09 15:24 ` [PATCH net-next v4 5/5] ARM: dts: qcom: ipq4019: Add description for the " Maxime Chevallier
2022-09-09 15:36 ` Krzysztof Kozlowski
2022-09-17 0:20 ` [PATCH net-next v4 0/5] net: ipqess: introduce Qualcomm IPQESS driver Vladimir Oltean
2022-09-17 9:02 ` Maxime Chevallier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220917110202.1b8562bf@fedora \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luka.perkov@sartura.hr \
--cc=netdev@vger.kernel.org \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).