From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC8B2C54EE9 for ; Sun, 18 Sep 2022 12:17:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229686AbiIRMRr (ORCPT ); Sun, 18 Sep 2022 08:17:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbiIRMRq (ORCPT ); Sun, 18 Sep 2022 08:17:46 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C8501D0E2 for ; Sun, 18 Sep 2022 05:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663503464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YIbilycgQyjenY282EZwIsPOR3PFZL895xpYAyq5afo=; b=YERIaMD3wuYcnSSHE5rUpWiQjkG8gGRR1lrtqwN26ySuPA3SXyOQXrtzXfk6ZlP/qdL2zq Wi8TSV4I/i5XFho/xPp5yJ51WtA/+yetS5HTmPeOqMVq2AQh4d2sAzk1UrI/UTaUTIJmFJ UAemRQH+Sj8Bz5IoUntKUlqtiwZCbBI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-387-MTLXidMRNJ6ojV0Z7zADYQ-1; Sun, 18 Sep 2022 08:17:42 -0400 X-MC-Unique: MTLXidMRNJ6ojV0Z7zADYQ-1 Received: by mail-wr1-f69.google.com with SMTP id r23-20020adfb1d7000000b002286358a916so5899932wra.3 for ; Sun, 18 Sep 2022 05:17:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=YIbilycgQyjenY282EZwIsPOR3PFZL895xpYAyq5afo=; b=z69Y8kHBRlDKpfUFTlT5rdTPao8qveISt/OR/dmJ7LFyViWIvA8PWneLprXbnflVkJ J7OTrDnk62lglXr8y0dNMC3Na6nsvYGmBOxq14roFRcRWScb76stWEKI1EUWHkwi7JSR HemihESMOHECsyBXwQ2mwKmiwB0xW4jrIYucACjxp1RVM1jiK74+BP1YKtU6gH//OKaz rNfZViGbuA1g8WCsZcKqxx5IDm9SRbmLlEh20zzVNRvPeuGj2iFSdaNFKtVZrfGMOdwn 0jq5/PgVGZMowHf+6yg2tAPPVgRbExlrOWmdNPOHmSIDoxXQi/ZSe06JIU9RhUEeoLZu 7ZVQ== X-Gm-Message-State: ACrzQf3OdVy7wMpDeFwdFpVgyf4U6+rLZClHBP60IxGnO8/Swdlh97dT krntSEuu/mYSTer1ZiEdSx4vQRJrtO2HXZXSDtf6KpKh3cuX0iJQtlAIIqa+s/dY89UumCv+Kiq VZg8pzlipYUaxniE/ X-Received: by 2002:a5d:4742:0:b0:22a:3a88:d9e6 with SMTP id o2-20020a5d4742000000b0022a3a88d9e6mr8183466wrs.438.1663503461618; Sun, 18 Sep 2022 05:17:41 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6OgKAiHsRIMsNcvcQlSELq9pAaD49wvj8xve/5Xz8Q2YgoqvtA0Jk9oZfbBvYoMf3nUdnFOQ== X-Received: by 2002:a5d:4742:0:b0:22a:3a88:d9e6 with SMTP id o2-20020a5d4742000000b0022a3a88d9e6mr8183456wrs.438.1663503461375; Sun, 18 Sep 2022 05:17:41 -0700 (PDT) Received: from redhat.com ([2.52.4.6]) by smtp.gmail.com with ESMTPSA id i7-20020a05600c354700b003b4cba4ef71sm4421682wmq.41.2022.09.18.05.17.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Sep 2022 05:17:40 -0700 (PDT) Date: Sun, 18 Sep 2022 08:17:36 -0400 From: "Michael S. Tsirkin" To: Junbo Cc: Jason Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH] Do not name control queue for virtio-net Message-ID: <20220918081713-mutt-send-email-mst@kernel.org> References: <20220917092857.3752357-1-junbo4242@gmail.com> <20220918025033-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Sep 18, 2022 at 05:00:20PM +0800, Junbo wrote: > hi Michael > > in virtio-net.c >     /* Parameters for control virtqueue, if any */ >     if (vi->has_cvq) { >         callbacks[total_vqs - 1] = NULL; >         names[total_vqs - 1] = "control"; >     } > > I think the Author who write the code wait, that was not you? > maybe want to name the control queue to > 'virtioX-control', but it never worked, we can see the name still be > 'virtioX-config' in /proc/interrupts, for example  >  43:          0          0          0          0          0          0         >  0          0   PCI-MSI-edge      virtio0-config >  44:         64          0          0          0          0          0       > 1845          0   PCI-MSI-edge      virtio0-input.0 >  45:          1          0          0          0          0          0         >  0          0   PCI-MSI-edge      virtio0-output.0 > > Because in function vp_request_msix_vectors, it just allocate 'xxxx-config' to > every virtio devices, even the virtio device do not need it. in /proc/ > interrupts, we can see that each virtio device's first interrupt always named > 'virtioX-config'. > > So I think it's better to not explicitly give the "control" here, it's > useless...   > > > Michael S. Tsirkin 于2022年9月18日周日 14:56写道： > > On Sat, Sep 17, 2022 at 09:28:57AM +0000, junbo4242@gmail.com wrote: > > From: Junbo > > > > In virtio drivers, the control queue always named -config. > > > > Signed-off-by: Junbo > > I don't think that's right. config is the config interrupt. > > > > > --- > >  drivers/net/virtio_net.c | 3 ++- > >  1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > index 9cce7dec7366..0b3e74cfe201 100644 > > --- a/drivers/net/virtio_net.c > > +++ b/drivers/net/virtio_net.c > > @@ -3469,7 +3469,8 @@ static int virtnet_find_vqs(struct virtnet_info > *vi) > >       /* Parameters for control virtqueue, if any */ > >       if (vi->has_cvq) { > >               callbacks[total_vqs - 1] = NULL; > > -             names[total_vqs - 1] = "control"; > > +             /* control virtqueue always named -config */ > > +             names[total_vqs - 1] = ""; > >       } > >  > >       /* Allocate/initialize parameters for send/receive virtqueues */ > > -- > > 2.31.1 > >