From: Stephen Hemminger <stephen@networkplumber.org>
To: Patrick Rohr <prohr@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
"Linux Network Development Mailing List" <netdev@vger.kernel.org>,
"Maciej Żenczykowski" <maze@google.com>,
"Lorenzo Colitti" <lorenzo@google.com>,
"Jason Wang" <jasowang@redhat.com>
Subject: Re: [PATCH] tun: support not enabling carrier in TUNSETIFF
Date: Mon, 19 Sep 2022 10:18:02 -0700 [thread overview]
Message-ID: <20220919101802.4f4d1a86@hermes.local> (raw)
In-Reply-To: <20220916234552.3388360-1-prohr@google.com>
On Fri, 16 Sep 2022 16:45:52 -0700
Patrick Rohr <prohr@google.com> wrote:
> diff --git a/include/uapi/linux/if_tun.h b/include/uapi/linux/if_tun.h
> index 2ec07de1d73b..12dde91957a5 100644
> --- a/include/uapi/linux/if_tun.h
> +++ b/include/uapi/linux/if_tun.h
> @@ -75,6 +75,8 @@
> #define IFF_MULTI_QUEUE 0x0100
> #define IFF_ATTACH_QUEUE 0x0200
> #define IFF_DETACH_QUEUE 0x0400
> +/* Used in TUNSETIFF to bring up tun/tap without carrier */
> +#define IFF_NO_CARRIER IFF_DETACH_QUEUE
Overloading a flag in existing user API is likely to break
some application somewhere...
next prev parent reply other threads:[~2022-09-19 17:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 23:45 [PATCH] tun: support not enabling carrier in TUNSETIFF Patrick Rohr
2022-09-16 23:54 ` Maciej Żenczykowski
2022-09-19 6:52 ` Jason Wang
2022-09-19 17:18 ` Stephen Hemminger [this message]
2022-09-20 0:01 ` Maciej Żenczykowski
2022-09-20 1:44 ` Jason Wang
2022-09-20 15:36 ` Stephen Hemminger
2022-09-20 19:48 ` [PATCH v2] " Patrick Rohr
2022-09-20 21:47 ` Maciej Żenczykowski
2022-09-21 2:53 ` Jason Wang
2022-09-21 6:35 ` Nicolas Dichtel
2022-09-23 11:10 ` patchwork-bot+netdevbpf
2022-09-20 7:35 ` [PATCH] " Nicolas Dichtel
2022-09-21 7:08 ` [tun] a4d8f18ebc: ltp.ioctl03.fail kernel test robot
2022-09-21 7:48 ` [LTP] " Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220919101802.4f4d1a86@hermes.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=lorenzo@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=prohr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).