From: Jakub Kicinski <kuba@kernel.org>
To: Sun Ke <sunke32@huawei.com>
Cc: <joyce.ooi@intel.com>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<linux@armlinux.org.uk>, <netdev@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH v2] net: ethernet: altera: TSE: fix error return code in altera_tse_probe()
Date: Mon, 19 Sep 2022 14:09:51 -0700 [thread overview]
Message-ID: <20220919140951.3dcdcba7@kernel.org> (raw)
In-Reply-To: <20220909024617.2584200-1-sunke32@huawei.com>
On Fri, 9 Sep 2022 10:46:17 +0800 Sun Ke wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: fef2998203e1 ("net: altera: tse: convert to phylink")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Sun Ke <sunke32@huawei.com>
You must CC Maxime, who authored the change under Fixes,
and is most likely the best person to give us a review.
Please repost with the CC fixed.
> diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
> index 89ae6d1623aa..3cf409bdb283 100644
> --- a/drivers/net/ethernet/altera/altera_tse_main.c
> +++ b/drivers/net/ethernet/altera/altera_tse_main.c
> @@ -1411,6 +1411,7 @@ static int altera_tse_probe(struct platform_device *pdev)
> priv->phy_iface, &alt_tse_phylink_ops);
> if (IS_ERR(priv->phylink)) {
> dev_err(&pdev->dev, "failed to create phylink\n");
> + ret = PTR_ERR(priv->phylink);
> goto err_init_phy;
> }
>
next prev parent reply other threads:[~2022-09-19 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 2:46 [PATCH v2] net: ethernet: altera: TSE: fix error return code in altera_tse_probe() Sun Ke
2022-09-19 21:09 ` Jakub Kicinski [this message]
2022-09-20 1:40 ` Sun Ke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220919140951.3dcdcba7@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joyce.ooi@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sunke32@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).