* [PATCH linux-next] mlxsw: core: remove the unneeded result variable
@ 2022-09-12 7:29 cgel.zte
2022-09-12 8:21 ` Ido Schimmel
2022-09-19 21:50 ` Jakub Kicinski
0 siblings, 2 replies; 3+ messages in thread
From: cgel.zte @ 2022-09-12 7:29 UTC (permalink / raw)
To: idosch
Cc: petrm, davem, edumazet, kuba, pabeni, netdev, linux-kernel,
Xu Panda, Zeal Robot
From: Xu Panda <xu.panda@zte.com.cn>
Return the value mlxsw_core_bus_device_register() directly instead of
storing it in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
---
drivers/net/ethernet/mellanox/mlxsw/core.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c
index e2a985ec2c76..8daedf6c4496 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/core.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/core.c
@@ -1513,15 +1513,13 @@ mlxsw_devlink_core_bus_device_reload_up(struct devlink *devlink, enum devlink_re
struct netlink_ext_ack *extack)
{
struct mlxsw_core *mlxsw_core = devlink_priv(devlink);
- int err;
*actions_performed = BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT) |
BIT(DEVLINK_RELOAD_ACTION_FW_ACTIVATE);
- err = mlxsw_core_bus_device_register(mlxsw_core->bus_info,
- mlxsw_core->bus,
- mlxsw_core->bus_priv, true,
- devlink, extack);
- return err;
+ return mlxsw_core_bus_device_register(mlxsw_core->bus_info,
+ mlxsw_core->bus,
+ mlxsw_core->bus_priv, true,
+ devlink, extack);
}
static int mlxsw_devlink_flash_update(struct devlink *devlink,
--
2.15.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH linux-next] mlxsw: core: remove the unneeded result variable
2022-09-12 7:29 [PATCH linux-next] mlxsw: core: remove the unneeded result variable cgel.zte
@ 2022-09-12 8:21 ` Ido Schimmel
2022-09-19 21:50 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Ido Schimmel @ 2022-09-12 8:21 UTC (permalink / raw)
To: cgel.zte
Cc: petrm, davem, edumazet, kuba, pabeni, netdev, linux-kernel,
Xu Panda, Zeal Robot
On Mon, Sep 12, 2022 at 07:29:34AM +0000, cgel.zte@gmail.com wrote:
> From: Xu Panda <xu.panda@zte.com.cn>
>
> Return the value mlxsw_core_bus_device_register() directly instead of
> storing it in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
For net-next:
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Please use "PATCH net-next" prefix for such patches:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#how-do-i-indicate-which-tree-net-vs-net-next-my-patch-should-be-in
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH linux-next] mlxsw: core: remove the unneeded result variable
2022-09-12 7:29 [PATCH linux-next] mlxsw: core: remove the unneeded result variable cgel.zte
2022-09-12 8:21 ` Ido Schimmel
@ 2022-09-19 21:50 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2022-09-19 21:50 UTC (permalink / raw)
To: cgel.zte
Cc: idosch, petrm, davem, edumazet, pabeni, netdev, linux-kernel,
Xu Panda, Zeal Robot
On Mon, 12 Sep 2022 07:29:34 +0000 cgel.zte@gmail.com wrote:
> From: Xu Panda <xu.panda@zte.com.cn>
>
> Return the value mlxsw_core_bus_device_register() directly instead of
> storing it in another redundant variable.
This patch does not apply cleanly to net-next, please rebase.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-19 21:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-12 7:29 [PATCH linux-next] mlxsw: core: remove the unneeded result variable cgel.zte
2022-09-12 8:21 ` Ido Schimmel
2022-09-19 21:50 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).