From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Russell King <linux@armlinux.org.uk>,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org,
Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Alexander 'lynxis' Couzens <lynxis@fe80.eu>
Subject: Re: [PATCH v2] net: dsa: mt7530: add support for in-band link status
Date: Mon, 19 Sep 2022 18:36:22 -0700 [thread overview]
Message-ID: <20220919183622.205ccabf@kernel.org> (raw)
In-Reply-To: <Yx5I6nRPxYIiC1ZT@makrotopia.org>
On Sun, 11 Sep 2022 21:45:30 +0100 Daniel Golle wrote:
> static void mt7531_pcs_get_state(struct phylink_pcs *pcs,
> struct phylink_link_state *state)
> {
> struct mt7530_priv *priv = pcs_to_mt753x_pcs(pcs)->priv;
> int port = pcs_to_mt753x_pcs(pcs)->port;
> + unsigned int val;
>
> - if (state->interface == PHY_INTERFACE_MODE_SGMII)
> + if (state->interface == PHY_INTERFACE_MODE_SGMII) {
> mt7531_sgmii_pcs_get_state_an(priv, port, state);
> - else
> - state->link = false;
> + return;
> + } else if ((state->interface == PHY_INTERFACE_MODE_1000BASEX) ||
> + (state->interface == PHY_INTERFACE_MODE_2500BASEX)) {
> + mt7531_sgmii_pcs_get_state_inband(priv, port, state);
> + return;
> + }
> +
> + state->link = false;
drivers/net/dsa/mt7530.c:3040:15: warning: unused variable 'val' [-Wunused-variable]
unsigned int val;
^
next prev parent reply other threads:[~2022-09-20 1:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-10 1:12 [PATCH] net: dsa: mt7530: add support for in-band link status Daniel Golle
2022-09-11 19:58 ` Russell King (Oracle)
2022-09-11 20:45 ` [PATCH v2] " Daniel Golle
2022-09-20 1:36 ` Jakub Kicinski [this message]
2022-09-20 22:28 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220919183622.205ccabf@kernel.org \
--to=kuba@kernel.org \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=lynxis@fe80.eu \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).