From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id ADDC7ECAAD8
	for <netdev@archiver.kernel.org>; Tue, 20 Sep 2022 14:29:57 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231206AbiITO3z (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Tue, 20 Sep 2022 10:29:55 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58084 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231195AbiITO3y (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 20 Sep 2022 10:29:54 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5449CDFF3;
        Tue, 20 Sep 2022 07:29:52 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 15C4962AE3;
        Tue, 20 Sep 2022 14:29:51 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B702AC433D6;
        Tue, 20 Sep 2022 14:29:49 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1663684190;
        bh=I2AZ4a5ewLRtZ+OVequFYRKX7N+DsK2ocVC2jmNUcy8=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=m8z7qP5xpdxGu6V+FBcbAokFPNddjLsAQxkYlWf/CecPLC3/GEv4XeX0spnREGC83
         lw1WvvY+oYo4wOklCruY8v8kvArRs0bZ38DIBRwjcqZb9a7RxvRuD/AWIqBixMvcoP
         ty+BFcQpMgVZRF6BR0qgcx0Pu01tSJ54+rzr19LaZ9dOZQtyUr76XkaqCOrMy9xPMM
         NWFHwru/o56ka0ttJzCB1P5YxJNbFNJaJgbC6ArDnnpB6FOMYdlKm+CQNsFyOWqn5h
         c8wGYyUx/FpTimpcW/GOrSBrO6In49DVYIZ9IibQ4NRZcn4q2tVn8Ok2WSECfJgRfI
         rbbp9ajXpcSVg==
Date:   Tue, 20 Sep 2022 07:29:48 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Casper Andersson <casper.casan@gmail.com>
Cc:     Nathan Huckleberry <nhuck@google.com>,
        Dan Carpenter <error27@gmail.com>, llvm@lists.linux.dev,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        UNGLinuxDriver@microchip.com,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: sparx5: Fix return type of sparx5_port_xmit_impl
Message-ID: <20220920072948.33c25dd2@kernel.org>
In-Reply-To: <20220913081548.gmngjwuagbt63j7h@wse-c0155>
References: <20220912214432.928989-1-nhuck@google.com>
        <20220913081548.gmngjwuagbt63j7h@wse-c0155>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Tue, 13 Sep 2022 10:15:48 +0200 Casper Andersson wrote:
> I noticed that the functions that assign the return value inside
> sparx5_port_xmit_impl also have return type int, which would ideally
> also be changed. But a bigger issue might be that
> sparx5_ptp_txtstamp_request and sparx5_inject (called inside
> sparx5_port_xmit_impl) returns -EBUSY (-16),

Yes, that seems off. IIUC error codes are treated as drops, 
but the driver doesn't free the frame. So it's likely a leak.

> when they should return NETDEV_TX_BUSY (16). If this is an issue then
> it also needs to be fixed.