* [PATCH v2] drivers/net/ethernet/intel/e100: check the return value of e100_exec_cmd()
@ 2022-09-17 0:10 Li Zhong
2022-09-20 18:36 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Li Zhong @ 2022-09-17 0:10 UTC (permalink / raw)
To: linux-kernel, netdev, intel-wired-lan
Cc: pabeni, kuba, edumazet, davem, anthony.l.nguyen, jesse.brandeburg,
Li Zhong
Check the return value of e100_exec_cmd() which could return error code
when execution fails.
Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
drivers/net/ethernet/intel/e100.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c
index 11a884aa5082..0d133cd4d01b 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel/e100.c
@@ -1911,7 +1911,9 @@ static inline void e100_start_receiver(struct nic *nic, struct rx *rx)
/* (Re)start RU if suspended or idle and RFA is non-NULL */
if (rx->skb) {
- e100_exec_cmd(nic, ruc_start, rx->dma_addr);
+ if (e100_exec_cmd(nic, ruc_start, rx->dma_addr))
+ netif_printk(nic, tx_err, KERN_DEBUG, nic->netdev,
+ "exec ruc_start failed\n");
nic->ru_running = RU_RUNNING;
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] drivers/net/ethernet/intel/e100: check the return value of e100_exec_cmd()
2022-09-17 0:10 [PATCH v2] drivers/net/ethernet/intel/e100: check the return value of e100_exec_cmd() Li Zhong
@ 2022-09-20 18:36 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-09-20 18:36 UTC (permalink / raw)
To: Li Zhong
Cc: linux-kernel, netdev, intel-wired-lan, pabeni, edumazet, davem,
anthony.l.nguyen, jesse.brandeburg
On Fri, 16 Sep 2022 17:10:27 -0700 Li Zhong wrote:
> Check the return value of e100_exec_cmd() which could return error code
> when execution fails.
You need to provide more detailed analysis in the commit message.
Right now it looks like you're just blindly finding cases where
return value is not checked and adding error checks. This is as
likely to fix something as it is to break.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-20 18:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-17 0:10 [PATCH v2] drivers/net/ethernet/intel/e100: check the return value of e100_exec_cmd() Li Zhong
2022-09-20 18:36 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).