From: Jakub Kicinski <kuba@kernel.org>
To: Li Zhong <floridsleeves@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, edumazet@google.com, davem@davemloft.net
Subject: Re: [PATCH v1] net/ethtool/tunnels: check the return value of nla_nest_start()
Date: Tue, 20 Sep 2022 11:37:44 -0700 [thread overview]
Message-ID: <20220920113744.64b16924@kernel.org> (raw)
In-Reply-To: <20220917022602.3843619-1-floridsleeves@gmail.com>
On Fri, 16 Sep 2022 19:26:02 -0700 Li Zhong wrote:
> goto err_cancel_table;
>
> entry = nla_nest_start(skb, ETHTOOL_A_TUNNEL_UDP_TABLE_ENTRY);
> + if (!entry)
> + return -EMSGSIZE;
not even correct, and completely harmless
next prev parent reply other threads:[~2022-09-20 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 2:26 [PATCH v1] net/ethtool/tunnels: check the return value of nla_nest_start() Li Zhong
2022-09-20 18:37 ` Jakub Kicinski [this message]
2022-09-20 19:31 ` Li Zhong
2022-09-20 19:41 ` Jakub Kicinski
2022-09-21 8:31 ` Li Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920113744.64b16924@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=floridsleeves@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).