From: Jakub Kicinski <kuba@kernel.org>
To: Jian Shen <shenjian15@huawei.com>
Cc: <davem@davemloft.net>, <ecree.xilinx@gmail.com>, <andrew@lunn.ch>,
<hkallweit1@gmail.com>, <alexandr.lobakin@intel.com>,
<saeed@kernel.org>, <leon@kernel.org>, <netdev@vger.kernel.org>,
<linuxarm@huawei.com>
Subject: Re: [RFCv8 PATCH net-next 02/55] net: replace general features macroes with global netdev_features variables
Date: Tue, 20 Sep 2022 13:12:33 -0700 [thread overview]
Message-ID: <20220920131233.61a1b28c@kernel.org> (raw)
In-Reply-To: <20220918094336.28958-3-shenjian15@huawei.com>
On Sun, 18 Sep 2022 09:42:43 +0000 Jian Shen wrote:
> -#define NETIF_F_NEVER_CHANGE (NETIF_F_VLAN_CHALLENGED | \
> - NETIF_F_LLTX | NETIF_F_NETNS_LOCAL)
> +#define NETIF_F_NEVER_CHANGE netdev_never_change_features
We shouldn't be changing all these defines here, because that breaks
the build AFAIU. Can we not use the lowercase names going forward?
next prev parent reply other threads:[~2022-09-20 20:12 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-18 9:42 [RFCv8 PATCH net-next 00/55] net: extend the type of netdev_features_t to bitmap Jian Shen
2022-09-18 9:42 ` [RFCv8 PATCH net-next 01/55] net: introduce operation helpers for netdev features Jian Shen
2022-09-20 20:10 ` Jakub Kicinski
2022-09-21 3:04 ` shenjian (K)
2022-09-18 9:42 ` [RFCv8 PATCH net-next 02/55] net: replace general features macroes with global netdev_features variables Jian Shen
2022-09-20 20:12 ` Jakub Kicinski [this message]
2022-09-21 6:33 ` shenjian (K)
2022-09-21 10:01 ` shenjian (K)
2022-09-21 12:50 ` Jakub Kicinski
2022-09-22 14:47 ` shenjian (K)
2022-09-18 9:42 ` [RFCv8 PATCH net-next 03/55] treewide: replace multiple feature bits with DECLARE_NETDEV_FEATURE_SET Jian Shen
2022-09-20 20:13 ` Jakub Kicinski
2022-09-18 9:42 ` [RFCv8 PATCH net-next 04/55] net: sfc: replace const features initialization " Jian Shen
2022-09-18 9:42 ` [RFCv8 PATCH net-next 05/55] net: atlantic: replace const features initialization with NETDEV_FEATURE_SET Jian Shen
2022-09-18 9:42 ` [RFCv8 PATCH net-next 06/55] iwlwifi: " Jian Shen
2022-09-18 9:42 ` [RFCv8 PATCH net-next 07/55] net: ethernet: mtk_eth_soc: " Jian Shen
2022-09-18 9:42 ` [RFCv8 PATCH net-next 08/55] ravb: " Jian Shen
2022-09-18 9:42 ` [RFCv8 PATCH net-next 09/55] test_bpf: " Jian Shen
2022-09-18 9:42 ` [RFCv8 PATCH net-next 10/55] treewide: replace NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK by netdev_csum_gso_features_mask Jian Shen
2022-09-18 9:42 ` [RFCv8 PATCH net-next 11/55] treewide: replace NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM by netdev_ip_csum_features Jian Shen
2022-09-18 9:42 ` [RFCv8 PATCH net-next 12/55] treewide: replace NETIF_F_TSO | NETIF_F_TSO6 by netdev_general_tso_features Jian Shen
2022-09-18 9:42 ` [RFCv8 PATCH net-next 13/55] treewide: replace VLAN tag feature array by const vlan features Jian Shen
2022-09-18 9:42 ` [RFCv8 PATCH net-next 14/55] net: simplify the netdev features expressions for xxx_gso_segment Jian Shen
2022-09-18 9:42 ` [RFCv8 PATCH net-next 15/55] treewide: simplify the netdev features expression Jian Shen
2022-09-18 9:42 ` [RFCv8 PATCH net-next 16/55] treewide: adjust the handle for netdev features '0' Jian Shen
2022-09-18 9:42 ` [RFCv8 PATCH net-next 17/55] treewide: adjust features initialization Jian Shen
2022-09-18 9:42 ` [RFCv8 PATCH net-next 18/55] net: mlx4: adjust the net device feature relative macroes Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 19/55] net: mlx5e: adjust " Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 20/55] net: mlxsw: adjust input parameter for function mlxsw_sp_handle_feature Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 21/55] net: iavf: adjust net device features relative macroes Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 22/55] net: core: adjust netdev_sync_xxx_features Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 23/55] net: adjust the build check for net_gso_ok() Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 24/55] treewide: use netdev_feature_add helpers Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 25/55] treewide: use netdev_features_or/set helpers Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 26/55] treewide: use netdev_feature_change helpers Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 27/55] treewide: use netdev_feature_del helpers Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 28/55] treewide: use netdev_features_andnot/clear helpers Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 29/55] treewide: use netdev_features_xor/toggle helpers Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 30/55] treewide: use netdev_feature_test helpers Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 31/55] treewide: use netdev_features_intersects helpers Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 32/55] treewide: use netdev_features_and/mask helpers Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 33/55] treewide: use netdev_features_subset helpers Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 34/55] treewide: use netdev_features_equal helpers Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 35/55] treewide: use netdev_features_empty helpers Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 36/55] net: adjust the prototype of netdev_increment_features() Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 37/55] net: adjust the prototype of netdev_add_tso_features() Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 38/55] net: core: adjust prototype of several functions used in net/core/dev.c Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 39/55] net: adjust the prototype of netdev_intersect_features() Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 40/55] net: adjust the prototype of netif_skb_features() Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 41/55] net: adjust the prototype of xxx_features_check() Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 42/55] net: adjust the prototype of ndo_fix_features Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 43/55] net: adjust the prototype of xxx_set_features() Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 44/55] net: adjust the prototype fo xxx_gso_segment() family Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 45/55] net: vlan: adjust the prototype of vlan functions Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 46/55] net: adjust the prototype of netif_needs_gso() and relative functions Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 47/55] net: adjust the prototype of skb_needs_linearize() Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 48/55] net: adjust the prototype of validate_xmit_xfrm() and relative functions Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 49/55] net: adjust the prototype of can_checksum_protocol() Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 50/55] net: tap: adjust the prototype of update_features() Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 51/55] net: mlx4: adjust the prototype of check_csum() and mlx4_en_update_loopback_state() Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 52/55] net: gve: adjust the prototype of gve_rx(), gve_clean_rx_done() and gve_rx_complete_skb() Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 53/55] net: sfc: adjust the prototype of xxx_supported_features() Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 54/55] treewide: use netdev_features_copy helpers Jian Shen
2022-09-18 9:43 ` [RFCv8 PATCH net-next 55/55] net: redefine the prototype of netdev_features_t Jian Shen
2022-09-20 20:16 ` [RFCv8 PATCH net-next 00/55] net: extend the type of netdev_features_t to bitmap Jakub Kicinski
2022-11-25 15:44 ` Alexander Lobakin
2022-11-28 15:22 ` shenjian (K)
2022-11-28 15:51 ` Alexander Lobakin
2023-09-13 10:28 ` Alexander Lobakin
2023-09-16 7:20 ` shenjian (K)
2023-09-18 14:25 ` Alexander Lobakin
2023-10-03 19:28 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920131233.61a1b28c@kernel.org \
--to=kuba@kernel.org \
--cc=alexandr.lobakin@intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=leon@kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=shenjian15@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).