From: Jakub Kicinski <kuba@kernel.org>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: Sevinj Aghayeva <sevinj.aghayeva@gmail.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
aroulin@nvidia.com, sbrivio@redhat.com, roopa@nvidia.com,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCH RFC net-next 0/5] net: vlan: fix bridge binding behavior and add selftests
Date: Tue, 20 Sep 2022 16:29:54 -0700 [thread overview]
Message-ID: <20220920162954.1f4aaf7b@kernel.org> (raw)
In-Reply-To: <78bd0e54-4ee3-bd3c-2154-9eb8b9a70497@blackwall.org>
On Tue, 20 Sep 2022 12:16:26 +0300 Nikolay Aleksandrov wrote:
> The set looks good to me, the bridge and vlan direct dependency is gone and
> the new notification type is used for passing link type specific info.
IDK, vlan knows it's calling the bridge:
+ if ((vlan->flags ^ old_flags) & VLAN_FLAG_BRIDGE_BINDING &&
+ netif_is_bridge_master(vlan->real_dev)) {
bridge knows it's vlan calling:
+ if (is_vlan_dev(dev)) {
+ br_vlan_device_event(dev, event, ptr);
going thru the generic NETDEV notifier seems odd.
If this is just to avoid the dependency we can perhaps add a stub
like net/ipv4/udp_tunnel_stub.c ?
> If the others are ok with it I think you can send it as non-RFC, but I'd give it
> a few more days at least. :)
next prev parent reply other threads:[~2022-09-20 23:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 20:17 [PATCH RFC net-next 0/5] net: vlan: fix bridge binding behavior and add selftests Sevinj Aghayeva
2022-09-17 20:17 ` [PATCH RFC net-next 1/5] net: core: export call_netdevice_notifiers_info Sevinj Aghayeva
2022-09-17 20:17 ` [PATCH RFC net-next 2/5] net: core: introduce a new notifier for link-type-specific changes Sevinj Aghayeva
2022-09-17 20:17 ` [PATCH RFC net-next 3/5] net: 8021q: notify bridge module of bridge-binding flag change Sevinj Aghayeva
2022-09-17 20:18 ` [PATCH RFC net-next 4/5] net: bridge: handle link-type-specific changes in the bridge module Sevinj Aghayeva
2022-09-30 13:11 ` [net] f6390526ee: WARNING:at_net/core/dev.c:#unregister_netdevice_many kernel test robot
2022-09-17 20:18 ` [PATCH RFC net-next 5/5] selftests: net: tests for bridge binding behavior Sevinj Aghayeva
2022-09-20 9:16 ` [PATCH RFC net-next 0/5] net: vlan: fix bridge binding behavior and add selftests Nikolay Aleksandrov
2022-09-20 23:29 ` Jakub Kicinski [this message]
2022-09-21 4:45 ` Nikolay Aleksandrov
2022-09-21 12:42 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920162954.1f4aaf7b@kernel.org \
--to=kuba@kernel.org \
--cc=aroulin@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=sbrivio@redhat.com \
--cc=sevinj.aghayeva@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).