From: Jakub Kicinski <kuba@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, kernel@pengutronix.de,
Yasuaki Ishimatsu <yasu.isimatu@gmail.com>
Subject: Re: [PATCH] net: fjes: Reorder symbols to get rid of a few forward declarations
Date: Tue, 20 Sep 2022 16:44:35 -0700 [thread overview]
Message-ID: <20220920164435.55c026d3@kernel.org> (raw)
In-Reply-To: <20220917225142.473770-1-u.kleine-koenig@pengutronix.de>
On Sun, 18 Sep 2022 00:51:42 +0200 Uwe Kleine-König wrote:
> Quite a few of the functions and other symbols defined in this driver had
> forward declarations. They can all be dropped after reordering them.
>
> This saves a few lines of code and reduces code duplication.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Any reason why do this? There's a ton of cobwebbed code with pointless
forward declarations. Do you have the HW and plan to work on the driver?
next prev parent reply other threads:[~2022-09-20 23:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 22:51 [PATCH] net: fjes: Reorder symbols to get rid of a few forward declarations Uwe Kleine-König
2022-09-20 23:44 ` Jakub Kicinski [this message]
2022-09-21 6:49 ` Uwe Kleine-König
2022-09-21 12:47 ` Jakub Kicinski
2022-09-22 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920164435.55c026d3@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).