From: Vladimir Oltean <olteanv@gmail.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH -next 1/3] net: dsa: microchip: remove unnecessary spi_set_drvdata()
Date: Wed, 21 Sep 2022 02:45:35 +0300 [thread overview]
Message-ID: <20220920234535.foehn5ugotbschfi@skbuf> (raw)
In-Reply-To: <20220913144406.2002409-1-yangyingliang@huawei.com>
On Tue, Sep 13, 2022 at 10:44:04PM +0800, Yang Yingliang wrote:
> Remove unnecessary spi_set_drvdata() in ksz_spi_remove(), the
> driver_data will be set to NULL in device_unbind_cleanup() after
> calling ->remove().
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
I would like all drivers in drivers/net/dsa/ to follow the same
convention, which they currently do. They all call .*_set_drvdata.*NULL
from ->remove(), why just patch the spi_set_drvdata() calls?
next prev parent reply other threads:[~2022-09-20 23:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 14:44 [PATCH -next 1/3] net: dsa: microchip: remove unnecessary spi_set_drvdata() Yang Yingliang
2022-09-13 14:44 ` [PATCH -next 2/3] net: dsa: sja1105: " Yang Yingliang
2022-09-13 14:44 ` [PATCH -next 3/3] net: dsa: vitesse-vsc73xx: " Yang Yingliang
2022-09-20 23:45 ` Vladimir Oltean [this message]
2022-09-21 1:32 ` [PATCH -next 1/3] net: dsa: microchip: " Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920234535.foehn5ugotbschfi@skbuf \
--to=olteanv@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox