From: Jakub Kicinski <kuba@kernel.org>
To: "Liang He" <windhl@126.com>
Cc: tchornyi@marvell.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, linux@armlinux.org.uk, netdev@vger.kernel.org
Subject: Re: [PATCH] net: marvell: Fix refcounting bugs in prestera_port_sfp_bind()
Date: Wed, 21 Sep 2022 05:36:35 -0700 [thread overview]
Message-ID: <20220921053635.06ad8511@kernel.org> (raw)
In-Reply-To: <5722f6ba.6204.1835f4924aa.Coremail.windhl@126.com>
On Wed, 21 Sep 2022 17:02:52 +0800 (CST) Liang He wrote:
> At 2022-09-21 08:45:29, "Jakub Kicinski" <kuba@kernel.org> wrote:
> >On Thu, 15 Sep 2022 12:06:55 +0800 Liang He wrote:
> >> In prestera_port_sfp_bind(), there are two refcounting bugs:
> >> (1) we should call of_node_get() before of_find_node_by_name() as
> >> it will automaitcally decrease the refcount of 'from' argument;
> >> (2) we should call of_node_put() for the break of the iteration
> >> for_each_child_of_node() as it will automatically increase and
> >> decrease the 'child'.
> >>
> >> Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
> >> Signed-off-by: Liang He <windhl@126.com>
> >
> >Please repost and CC all the authors of the patch under Fixes.
>
> Thanks for your reply, Jakub
>
> As I was the only one author, you mean following tag format:
>
> ""
> Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
> CC: Liang He <windhl@126.com>
> Signed-off-by: Liang He <windhl@126.com>
No, no, CC the authors of the patch under fixes, which is to say -
the patch which introduced the problem. The fixes tag you have is:
Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
so:
commit 52323ef75414d60b17f683076833eb55a6bffa2b
Author: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Date: Tue Jul 19 13:57:16 2022 +0300
net: marvell: prestera: add phylink support
For SFP port prestera driver will use kernel
phylink infrastucture to configure port mode based on
the module that has beed inserted
Co-developed-by: Yevhen Orlov <yevhen.orlov@plvision.eu>
Signed-off-by: Yevhen Orlov <yevhen.orlov@plvision.eu>
Co-developed-by: Taras Chornyi <taras.chornyi@plvision.eu>
Signed-off-by: Taras Chornyi <taras.chornyi@plvision.eu>
Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Signed-off-by: David S. Miller <davem@davemloft.net>
I was asking to also CC Yevhen and Oleksandr. Taras seems already CCed.
next prev parent reply other threads:[~2022-09-21 12:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 4:06 [PATCH] net: marvell: Fix refcounting bugs in prestera_port_sfp_bind() Liang He
2022-09-21 0:45 ` Jakub Kicinski
2022-09-21 9:02 ` Liang He
2022-09-21 12:36 ` Jakub Kicinski [this message]
2022-09-21 13:26 ` Liang He
-- strict thread matches above, loose matches on Subject: below --
2022-09-21 13:32 Liang He
2022-09-21 22:47 ` Yevhen Orlov
2022-09-22 14:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220921053635.06ad8511@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tchornyi@marvell.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).