From: Jakub Kicinski <kuba@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Yasuaki Ishimatsu" <yasu.isimatu@gmail.com>
Cc: netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
kernel@pengutronix.de, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: fjes: Reorder symbols to get rid of a few forward declarations
Date: Wed, 21 Sep 2022 05:47:09 -0700 [thread overview]
Message-ID: <20220921054709.150841af@kernel.org> (raw)
In-Reply-To: <20220921064935.t24cjwgkesjr5ebn@pengutronix.de>
On Wed, 21 Sep 2022 08:49:35 +0200 Uwe Kleine-König wrote:
> On Tue, Sep 20, 2022 at 04:44:35PM -0700, Jakub Kicinski wrote:
> > On Sun, 18 Sep 2022 00:51:42 +0200 Uwe Kleine-König wrote:
> > > Quite a few of the functions and other symbols defined in this driver had
> > > forward declarations. They can all be dropped after reordering them.
> > >
> > > This saves a few lines of code and reduces code duplication.
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >
> > Any reason why do this?
>
> The motivation was a breakage I introduced in another driver when I
> changed the prototype of a function and failed to adapt the declaration.
> (See 2dec3a7a7beb ("macintosh/ams: Adapt declaration of ams_i2c_remove()
> to earlier change") in today's next for the ugly details.)
>
> Currently I work on changing the prototype for the remove callback of
> platform drivers. So the patch here is prepatory work to make the latter
> change easier to do and review.
>
> > There's a ton of cobwebbed code with pointless forward declarations.
>
> For sure I won't address all of them. But if I stumble over one and find
> a few spare minutes I fix one at a time.
>
> > Do you have the HW and plan to work on the driver?
>
> I neither have the hardware nor do I plan to work on the driver. It's
> just a platform driver I might touch at some point in the future to
> adapt for a core driver change.
Alright, let me ask the obligatory question - Yasuaki is there any
chance that this driver is obsolete? I presume not, so would you be
willing to volunteer as the maintainer to review related patches?
next prev parent reply other threads:[~2022-09-21 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 22:51 [PATCH] net: fjes: Reorder symbols to get rid of a few forward declarations Uwe Kleine-König
2022-09-20 23:44 ` Jakub Kicinski
2022-09-21 6:49 ` Uwe Kleine-König
2022-09-21 12:47 ` Jakub Kicinski [this message]
2022-09-22 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220921054709.150841af@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).