From: Jakub Kicinski <kuba@kernel.org>
To: Li Zhong <floridsleeves@gmail.com>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com,
davem@davemloft.net
Subject: Re: [PATCH net-next v2] net/ethtool/tunnels: check the return value of nla_nest_start()
Date: Wed, 21 Sep 2022 06:07:29 -0700 [thread overview]
Message-ID: <20220921060729.7443f3d2@kernel.org> (raw)
In-Reply-To: <20220921083004.1612113-1-floridsleeves@gmail.com>
On Wed, 21 Sep 2022 01:30:04 -0700 Li Zhong wrote:
> Subject: [PATCH net-next v2] net/ethtool/tunnels: check the return value of nla_nest_start()
Please update the subject to follow the standard kernel convention.
The prefix should be something like
ethtool: tunnels:
or just
ethtool:
> Check the return value of nla_nest_start(). When starting the entry
> level nested attributes, if the tailroom of socket buffer is
> insufficient to store the attribute header and payload, the return value
> will be NULL and we should check it. If it is NULL, go to the
> error_cancel_entry label to do error handling.
Better but don't explain what the patch does but lean more into the
assessment of the situation. The last sentence is unnecessary, but
you should include an explanation if there is any _actual_ bug here.
Can something crash or misbehave?
> v2: error handling jump to error_cancel_entry, more details in commit
> meesage
This should go under the --- separator
prev parent reply other threads:[~2022-09-21 13:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 8:30 [PATCH net-next v2] net/ethtool/tunnels: check the return value of nla_nest_start() Li Zhong
2022-09-21 13:07 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220921060729.7443f3d2@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=floridsleeves@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).