From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E653CECAAD8 for ; Wed, 21 Sep 2022 20:29:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230452AbiIUU3f (ORCPT ); Wed, 21 Sep 2022 16:29:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229638AbiIUU3d (ORCPT ); Wed, 21 Sep 2022 16:29:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7842DD86 for ; Wed, 21 Sep 2022 13:29:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 12F4A6292B for ; Wed, 21 Sep 2022 20:29:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15E3BC433C1; Wed, 21 Sep 2022 20:29:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663792170; bh=drXLtze76SLhP3VZlGlEaOcbcKLjB0BFmy/WuYAdqn4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BH0Mjw/XXwntfwl0bZpnG5pCAYgUqDshgyL3mNxyeFsGRyujIYIWihiBZ4KL8hws5 hGCL7eyDRexVxGFPARaqoNJ7f1SIiDR302OBG3dCuRW1ZUOXHG3o0BvjnAkunTsNxb O6OX35s6CfCjEKUgpHVZUWAdpNq4Il6npo8vMS0S3PJZogvIABJj47XRPdAQHbhyeh xywZDdLLDVI0ciWV9zYBbaPjlWjdUKy+2dlLlbxVuY9r95Xql/2nyAQma8Grk/KUpJ ybMQ8KFZiCVcRQE9GauzoK5hD+dvwZjm8GKIpxWzLRWjEaLBXAPgxArMV9S7WSXBQw MtfF9MM3LK3VA== Date: Wed, 21 Sep 2022 13:29:29 -0700 From: Jakub Kicinski To: Amritha Nambiar Cc: netdev@vger.kernel.org, alexander.duyck@gmail.com, jhs@mojatatu.com, jiri@resnulli.us, xiyou.wangcong@gmail.com, vinicius.gomes@intel.com, sridhar.samudrala@intel.com Subject: Re: [net-next PATCH v2 0/4] Extend action skbedit to RX queue mapping Message-ID: <20220921132929.3f4ca04d@kernel.org> In-Reply-To: <166260012413.81018.8010396115034847972.stgit@anambiarhost.jf.intel.com> References: <166260012413.81018.8010396115034847972.stgit@anambiarhost.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 07 Sep 2022 18:23:57 -0700 Amritha Nambiar wrote: > Based on the discussion on > https://lore.kernel.org/netdev/20220429171717.5b0b2a81@kernel.org/, > the following series extends skbedit tc action to RX queue mapping. > Currently, skbedit action in tc allows overriding of transmit queue. > Extending this ability of skedit action supports the selection of receive > queue for incoming packets. Offloading this action is added for receive > side. Enabled ice driver to offload this type of filter into the > hardware for accepting packets to the device's receive queue. > > v2: Added documentation in Documentation/networking Alex and I had a quick chat about this, I think we can work around the difficulties with duplicating the behavior in SW by enforcing that the action can only be used with skip_sw. Either skbedit or Alex's suggested approach with act_mirred. Or new hw-only action. Alex pointed out that it'd be worth documenting the priorities of aRFS vs this thing, which one will be used if HW matches both.