From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Fedorenko <vfedorenko@novek.ru>
Cc: Michael Chan <michael.chan@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH net v2] bnxt_en: replace reset with config timestamps
Date: Wed, 21 Sep 2022 17:38:18 -0700 [thread overview]
Message-ID: <20220921173818.305eb52e@kernel.org> (raw)
In-Reply-To: <20220921224430.20395-1-vfedorenko@novek.ru>
On Thu, 22 Sep 2022 01:44:30 +0300 Vadim Fedorenko wrote:
> + if (ptp->rx_filter == PORT_MAC_CFG_REQ_FLAGS_ALL_RX_TS_CAPTURE_ENABLE) {
Doesn't ptp->rx_filter hold the uAPI values, i.e. HWTSTAMP_FILTER_* ?
> + rc = bnxt_close_nic(bp, false, false);
> + if (!rc)
> + rc = bnxt_open_nic(bp, false, false);
> + } else
> + bnxt_ptp_cfg_tstamp_filters(bp);
nit: missing brackets around the else branch
next prev parent reply other threads:[~2022-09-22 0:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 22:44 [PATCH net v2] bnxt_en: replace reset with config timestamps Vadim Fedorenko
2022-09-22 0:38 ` Jakub Kicinski [this message]
2022-09-22 19:09 ` Vadim Fedorenko
2022-09-22 0:39 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220921173818.305eb52e@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pavan.chebbi@broadcom.com \
--cc=richardcochran@gmail.com \
--cc=vfedorenko@novek.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).