From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 03CC4ECAAD8
	for <netdev@archiver.kernel.org>; Thu, 22 Sep 2022 00:38:24 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229663AbiIVAiW (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Wed, 21 Sep 2022 20:38:22 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48756 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229459AbiIVAiV (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 21 Sep 2022 20:38:21 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B22AAA9271
        for <netdev@vger.kernel.org>; Wed, 21 Sep 2022 17:38:20 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 49601629F5
        for <netdev@vger.kernel.org>; Thu, 22 Sep 2022 00:38:20 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57B32C433D6;
        Thu, 22 Sep 2022 00:38:19 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1663807099;
        bh=lUVW+R5gSBFBjd/SIsi9InTtmTTHtBIIfAOYHSKwecs=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=d0kYf24rGt9AGwINSDj+WBLEs6ESWIbBmlnmAX1ke58q858Fuk2t1lnDpPwVbQzPi
         YjibroIvJMw4GwpcrnBMs/IFsLAGXEInhS8vOS497TlzSi7iV5wXlAtvIhbZnr27mZ
         f7TYBtuG54Q40/MaT7ruj/v+NoASevDqbijOQyIF8pCJrVTCFC1NH1/mfXh9drxGef
         sOI+xJXbRQQitV8raEHtk8X30Kb0MnU9e/J9Hug5QyB4K+8aez8xqCFq3oqW0GafWr
         IiNXoHBZRDYFmWmY1z8t9GBh6oa/8PukcbieTUFdljuSDiBFxTQ/b5ToURBcyyKOYL
         DQsYxdLepzSsA==
Date:   Wed, 21 Sep 2022 17:38:18 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Vadim Fedorenko <vfedorenko@novek.ru>
Cc:     Michael Chan <michael.chan@broadcom.com>,
        Pavan Chebbi <pavan.chebbi@broadcom.com>,
        netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH net v2] bnxt_en: replace reset with config timestamps
Message-ID: <20220921173818.305eb52e@kernel.org>
In-Reply-To: <20220921224430.20395-1-vfedorenko@novek.ru>
References: <20220921224430.20395-1-vfedorenko@novek.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Thu, 22 Sep 2022 01:44:30 +0300 Vadim Fedorenko wrote:
> +		if (ptp->rx_filter == PORT_MAC_CFG_REQ_FLAGS_ALL_RX_TS_CAPTURE_ENABLE) {

Doesn't ptp->rx_filter hold the uAPI values, i.e. HWTSTAMP_FILTER_* ?

> +			rc = bnxt_close_nic(bp, false, false);
> +			if (!rc)
> +				rc = bnxt_open_nic(bp, false, false);
> +		} else
> +			bnxt_ptp_cfg_tstamp_filters(bp);

nit: missing brackets around the else branch