From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9879CC6FA90 for ; Thu, 22 Sep 2022 09:17:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230187AbiIVJRO (ORCPT ); Thu, 22 Sep 2022 05:17:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229762AbiIVJRM (ORCPT ); Thu, 22 Sep 2022 05:17:12 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B64F6D01E9 for ; Thu, 22 Sep 2022 02:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663838230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kQfJsNBklEQnlLpVZNYjFz1njaLl7T8B+cRrquogK3o=; b=ClBDFzKp4yJtLoAki63cOIoOmqhfy1RfGGxcJ+JSzR34OEHAvZLXC8VowAXCNcLQtr5CEh dKDSh5cLkY3afC8QuTnDw1BZT03BnqlVcVxxpjQVOxw03p5yaTcFTWjgHRDmp+bscrnNBB 1NxlXrrhP3e3GdIa5/XEggjHDCAOVzw= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-564-oTj6TP8sPJKioBqRJiy2NQ-1; Thu, 22 Sep 2022 05:17:09 -0400 X-MC-Unique: oTj6TP8sPJKioBqRJiy2NQ-1 Received: by mail-ed1-f69.google.com with SMTP id i17-20020a05640242d100b0044f18a5379aso6331314edc.21 for ; Thu, 22 Sep 2022 02:17:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=kQfJsNBklEQnlLpVZNYjFz1njaLl7T8B+cRrquogK3o=; b=PdDZEWpGchWlk7pSd0/9vcXEPu0CCM5T7iFh/wQl/s4iSk1H8OEPwUCtLM62SDST6B dtT7/Fgzn3xRtavsXbOuYkQn9O8XSB9J33j3WOFCAS2ce/rm04agf0L/P1QeMNub4rUU l1Z2z8ASsGifVyRul5rH+bUZsUJzq4fyU0F8/NNIuUORcEYdDd5P7IGgHrWB7V3IxVO6 dNxrsRV4eS4qWgqDM86InLbEJVzQ5L+q3USXmd0BnV8YG3pPzwGFFeFJ3nftlYRwlKTt fXG/SXiMhZFscGACK8e2EtHEHYZ884HQOjwTlqMiXTLL3Jo8HHFYfCjGqDwrK8kMfYRT m0Dg== X-Gm-Message-State: ACrzQf33tsoegm8qOfww6Adf0DPEiPys0PArGz4HCA95Rjl89qc7FsHP VeYJTwyQa6teG4VGf65UTYFg7ccVp9iCWXgwzUMZ3VrH5fZucsRYf06zL3IGRX+Udb/bVKcZHmb as8WtLWs6Zd+23WJO X-Received: by 2002:a17:907:d07:b0:72e:ec79:ad0f with SMTP id gn7-20020a1709070d0700b0072eec79ad0fmr2019354ejc.296.1663838228512; Thu, 22 Sep 2022 02:17:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6aWYk2gLkly55RZes2gWKaV2mpYmlQSmVpIR2XSzCn6t3IkeaTpYNPXd0NwzuX13AYtWwYqg== X-Received: by 2002:a17:907:d07:b0:72e:ec79:ad0f with SMTP id gn7-20020a1709070d0700b0072eec79ad0fmr2019336ejc.296.1663838228336; Thu, 22 Sep 2022 02:17:08 -0700 (PDT) Received: from redhat.com ([2.55.16.18]) by smtp.gmail.com with ESMTPSA id d14-20020a170906304e00b0073bf84be798sm2374187ejd.142.2022.09.22.02.17.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Sep 2022 02:17:07 -0700 (PDT) Date: Thu, 22 Sep 2022 05:17:03 -0400 From: "Michael S. Tsirkin" To: Paolo Abeni Cc: Junbo , Jesper Dangaard Brouer , Daniel Borkmann , netdev@vger.kernel.org, John Fastabend , Alexei Starovoitov , virtualization@lists.linux-foundation.org, Eric Dumazet , Jakub Kicinski , bpf@vger.kernel.org, "David S. Miller" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Do not name control queue for virtio-net Message-ID: <20220922051613-mutt-send-email-mst@kernel.org> References: <20220917092857.3752357-1-junbo4242@gmail.com> <20220918025033-mutt-send-email-mst@kernel.org> <20220918081713-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Sep 22, 2022 at 11:10:37AM +0200, Paolo Abeni wrote: > On Sun, 2022-09-18 at 08:17 -0400, Michael S. Tsirkin wrote: > > On Sun, Sep 18, 2022 at 05:00:20PM +0800, Junbo wrote: > > > hi Michael > > > > > > in virtio-net.c > > >     /* Parameters for control virtqueue, if any */ > > >     if (vi->has_cvq) { > > >         callbacks[total_vqs - 1] = NULL; > > >         names[total_vqs - 1] = "control"; > > >     } > > > > > > I think the Author who write the code > > > > wait, that was not you? > > I believe 'the Author' refers to the author of the current code, not to > the author of the patch. Oh I see. Responded. > @Junbo: the control queue is created only if the VIRTIO_NET_F_CTRL_VQ > feature is set, please check that in your setup. > > Thanks > > Paolo -- MST