From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: Guillaume Nault <gnault@redhat.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Ido Schimmel <idosch@nvidia.com>,
Petr Machata <petrm@nvidia.com>,
Florent Fourcot <florent.fourcot@wifirst.fr>,
Nikolay Aleksandrov <razor@blackwall.org>
Subject: Re: [PATCH net-next] rtnetlink: Honour NLM_F_ECHO flag in rtnl_{new, set}link
Date: Thu, 22 Sep 2022 05:58:53 -0700 [thread overview]
Message-ID: <20220922055853.529873ad@kernel.org> (raw)
In-Reply-To: <Yyw1TRSMRUbmOOtK@Laptop-X1>
On Thu, 22 Sep 2022 18:13:33 +0800 Hangbin Liu wrote:
> > In general I still don't think NLM_F_ECHO makes for a reasonable API.
> > It may seem okay to those who are willing to write manual netlink
> > parsers but for a normal programmer the ability to receive directly
> > notifications resulting from a API call they made is going to mean..
> > nothing they can have prior experience with. NEWLINK should have
> > reported the allocated handle / ifindex from the start :(
> >
> > The "give me back the notifications" semantics match well your use
> > case to log what the command has done, in that case there is no need
> > to "return" all the notifications from the API call.
>
> I didn't get what you mean about "no need to return all the notifications from
> the API call"? Do you ask for some update of the patch, or just talking about
> your propose of NEWLINK?
I'm talking about building "normal programmer" facing libraries on top
of netlink. The concept of ECHO fits very poorly into the normal
request-response semantics.
next prev parent reply other threads:[~2022-09-22 12:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 3:07 [PATCH net-next] rtnetlink: Honour NLM_F_ECHO flag in rtnl_{new, set}link Hangbin Liu
2022-09-21 9:11 ` Nicolas Dichtel
2022-09-21 10:31 ` Hangbin Liu
2022-09-21 13:01 ` Jakub Kicinski
2022-09-21 13:13 ` Nikolay Aleksandrov
2022-09-21 16:14 ` Guillaume Nault
2022-09-21 22:56 ` Jakub Kicinski
2022-09-22 10:13 ` Hangbin Liu
2022-09-22 12:58 ` Jakub Kicinski [this message]
2022-09-22 10:52 ` Florent Fourcot
2022-09-22 11:09 ` Guillaume Nault
2022-09-22 13:03 ` Jakub Kicinski
2022-09-22 14:51 ` Guillaume Nault
2022-09-23 8:43 ` Nicolas Dichtel
2022-09-23 13:48 ` Jakub Kicinski
2022-09-23 15:42 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922055853.529873ad@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florent.fourcot@wifirst.fr \
--cc=gnault@redhat.com \
--cc=idosch@nvidia.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).