From: Jakub Kicinski <kuba@kernel.org>
To: Guillaume Nault <gnault@redhat.com>
Cc: Hangbin Liu <liuhangbin@gmail.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Ido Schimmel <idosch@nvidia.com>,
Petr Machata <petrm@nvidia.com>,
Florent Fourcot <florent.fourcot@wifirst.fr>,
Nikolay Aleksandrov <razor@blackwall.org>
Subject: Re: [PATCH net-next] rtnetlink: Honour NLM_F_ECHO flag in rtnl_{new, set}link
Date: Thu, 22 Sep 2022 06:03:46 -0700 [thread overview]
Message-ID: <20220922060346.280b3af8@kernel.org> (raw)
In-Reply-To: <20220922110951.GA21605@debian.home>
On Thu, 22 Sep 2022 13:09:51 +0200 Guillaume Nault wrote:
> That's why I complained when RTM_NEWNSID tried to implement its own
> notification mechanism:
> https://lore.kernel.org/netdev/20191003161940.GA31862@linux.home/
>
> I mean, let's just use the built-in mechanism, rather than reinventing
> a new one every time the need comes up.
See, when you say "let's just use the built-in mechanism" you worry
me again. Let's be clear that no new API should require the use of
ECHO for normal operation, like finding out what the handle of an
allocated object is.
next prev parent reply other threads:[~2022-09-22 13:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 3:07 [PATCH net-next] rtnetlink: Honour NLM_F_ECHO flag in rtnl_{new, set}link Hangbin Liu
2022-09-21 9:11 ` Nicolas Dichtel
2022-09-21 10:31 ` Hangbin Liu
2022-09-21 13:01 ` Jakub Kicinski
2022-09-21 13:13 ` Nikolay Aleksandrov
2022-09-21 16:14 ` Guillaume Nault
2022-09-21 22:56 ` Jakub Kicinski
2022-09-22 10:13 ` Hangbin Liu
2022-09-22 12:58 ` Jakub Kicinski
2022-09-22 10:52 ` Florent Fourcot
2022-09-22 11:09 ` Guillaume Nault
2022-09-22 13:03 ` Jakub Kicinski [this message]
2022-09-22 14:51 ` Guillaume Nault
2022-09-23 8:43 ` Nicolas Dichtel
2022-09-23 13:48 ` Jakub Kicinski
2022-09-23 15:42 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922060346.280b3af8@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florent.fourcot@wifirst.fr \
--cc=gnault@redhat.com \
--cc=idosch@nvidia.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).