From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36AEDC54EE9 for ; Thu, 22 Sep 2022 15:23:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232127AbiIVPXz (ORCPT ); Thu, 22 Sep 2022 11:23:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232026AbiIVPXw (ORCPT ); Thu, 22 Sep 2022 11:23:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F861F858A for ; Thu, 22 Sep 2022 08:23:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AB75C6361D for ; Thu, 22 Sep 2022 15:23:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4DD3C433D6; Thu, 22 Sep 2022 15:23:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663860231; bh=LAEX5cCEFf1NDGEF0tN2HavSK3D8M6bseQWsmZQhkWQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LY3Obt99UC79MQAXv6L2NQsle92FI0ztsf8vP+PIKjjKGIyoadWnFrDxzZieVoQSc 6j6xur17ZLxqp++ifsEOFwPG5SrWK4hDVzpI46QrQNPwVOY14WLK9P30hpU2QJ+N+u aEvFP5T10hVRTu/cVq2fusnU3XTVOgr4iLpPwpzsEWl/2q6LHDaOqjdd7DxIfLgh7L YGcKVpgZzoVxyswtB3Yx1znVG3RJ6OSESrZaYt3jbuiGe6RKwTn7puj/kK0wyNaF39 o4go38w1HN43r5EUk/EbdhGzAKnx4qC04M5fnlHAsLU8jqcp3htEg4vceuSNLlD+XX cgs0JLtI7B/Sw== Date: Thu, 22 Sep 2022 08:23:49 -0700 From: Jakub Kicinski To: Daniel Borkmann Cc: Paul Blakey , Vlad Buslov , Oz Shlomo , Roi Dayan , netdev@vger.kernel.org, Saeed Mahameed , Eric Dumazet , "David S. Miller" , Paolo Abeni Subject: Re: [PATCH net 1/1] net: Fix return value of qdisc ingress handling on success Message-ID: <20220922082349.18fb65d6@kernel.org> In-Reply-To: <2338579f-689f-4891-ec58-22ac4046dd5a@iogearbox.net> References: <1663750248-20363-1-git-send-email-paulb@nvidia.com> <20220921074854.48175d87@kernel.org> <2338579f-689f-4891-ec58-22ac4046dd5a@iogearbox.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 22 Sep 2022 16:47:14 +0200 Daniel Borkmann wrote: > >> Looks reasonable and aligns with sch_handle_egress() fwiw. I think your Fixes tag is wrong > >> since that commit didn't modify any of the above. This patch should also rather go to net-next > >> tree to make sure it has enough soak time to catch potential regressions from this change in > >> behavior. > > > > I don't think we do "soak time" in networking. Perhaps we can try > > to use the "CC: stable # after 4 weeks" delay mechanism which Greg > > promised at LPC? > > Isn't that implicit? If the commit has Fixes tag and lands in net-next, stable team > anyway automatically pulls it once everything lands in Linus' tree via merge win and > then does the backporting for stable. What I meant is we don't merge fixes into net-next directly. Perhaps that's my personal view, not shared by other netdev maintainers. To me the 8 rc release process is fairly arbitrary timing wise. The fixes continue flowing in after Linus cuts final, plus only after a few stable releases the kernel makes it to a wide audience. Putting a fix in -next gives us anywhere between 0 and 8 weeks of delay. Explicit delay on the tag seems much more precise and independent of where we are in the release cycle. The cases where we put something in -next, later it becomes urgent and we can't get it to stable stand out in my memory much more than problems introduced late in the rc cycle.