From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99538C32771 for ; Mon, 26 Sep 2022 08:50:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233803AbiIZIuj (ORCPT ); Mon, 26 Sep 2022 04:50:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233680AbiIZIu1 (ORCPT ); Mon, 26 Sep 2022 04:50:27 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 482E41B7BE; Mon, 26 Sep 2022 01:50:26 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1ocjog-00037R-1a; Mon, 26 Sep 2022 10:50:18 +0200 Date: Mon, 26 Sep 2022 10:50:18 +0200 From: Florian Westphal To: Herbert Xu Cc: Florian Westphal , netdev@vger.kernel.org, tgraf@suug.ch, urezki@gmail.com, Paolo Abeni , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Martin Zaharinov , Michal Hocko , Paolo Bonzini , kvm@vger.kernel.org Subject: Re: [PATCH net] rhashtable: fix crash due to mm api change Message-ID: <20220926085018.GA11304@breakpoint.cc> References: <20220926083139.48069-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Herbert Xu wrote: > On Mon, Sep 26, 2022 at 10:31:39AM +0200, Florian Westphal wrote: > > > > This patch is partial revert of > > commit 93f976b5190d ("lib/rhashtable: simplify bucket_table_alloc()"), > > to avoid kvmalloc for ATOMIC case. > > This patch should just be reverted. If kvzalloc fails we should > definitely know about it. No idea what you mean, I am no mind reader. Please consider fixing this yourself, I am done with this crap.