From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 0293FC32771
	for <netdev@archiver.kernel.org>; Mon, 26 Sep 2022 10:06:04 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234767AbiIZKGC (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 26 Sep 2022 06:06:02 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58822 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233902AbiIZKGB (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 26 Sep 2022 06:06:01 -0400
Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F5E6371BD;
        Mon, 26 Sep 2022 03:06:00 -0700 (PDT)
Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92)
        (envelope-from <fw@strlen.de>)
        id 1ockzm-0003bT-DZ; Mon, 26 Sep 2022 12:05:50 +0200
Date:   Mon, 26 Sep 2022 12:05:50 +0200
From:   Florian Westphal <fw@strlen.de>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Florian Westphal <fw@strlen.de>, netdev@vger.kernel.org,
        tgraf@suug.ch, urezki@gmail.com, Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org,
        akpm@linux-foundation.org, Martin Zaharinov <micron10@gmail.com>,
        Michal Hocko <mhocko@suse.com>,
        Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH net] rhashtable: fix crash due to mm api change
Message-ID: <20220926100550.GA12777@breakpoint.cc>
References: <20220926083139.48069-1-fw@strlen.de>
 <YzFkt744uWI4y3Sv@gondor.apana.org.au>
 <20220926085018.GA11304@breakpoint.cc>
 <YzFyz5FWn50rhLsH@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YzFyz5FWn50rhLsH@gondor.apana.org.au>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Mon, Sep 26, 2022 at 10:50:18AM +0200, Florian Westphal wrote:
> > Herbert Xu <herbert@gondor.apana.org.au> wrote:
> > > On Mon, Sep 26, 2022 at 10:31:39AM +0200, Florian Westphal wrote:
> > > >
> > > > This patch is partial revert of
> > > > commit 93f976b5190d ("lib/rhashtable: simplify bucket_table_alloc()"),
> > > > to avoid kvmalloc for ATOMIC case.
> > > 
> > > This patch should just be reverted.  If kvzalloc fails we should
> > > definitely know about it.
> > 
> > No idea what you mean, I am no mind reader.  Please consider
> > fixing this yourself, I am done with this crap.
> 
> I just meant that the patch quoted above should be completely
> reverted instead of partially reverted.

I don't understand that at all, since this means removal of
__GFP_NOWARN -- that makes no sense to me.