From: Jakub Kicinski <kuba@kernel.org>
To: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<linux-kernel@vger.kernel.org>, <bryan.whitehead@microchip.com>,
<richardcochran@gmail.com>, <edumazet@google.com>,
<pabeni@redhat.com>, <UNGLinuxDriver@microchip.com>,
<Ian.Saturley@microchip.com>
Subject: Re: [PATCH net V2] net: lan743x: Fixes: 60942c397af6 ("Add support for PTP-IO Event Input External Timestamp (extts)")
Date: Mon, 26 Sep 2022 13:04:29 -0700 [thread overview]
Message-ID: <20220926130429.3ffd78b1@kernel.org> (raw)
In-Reply-To: <20220923094134.10477-1-Raju.Lakkaraju@microchip.com>
On Fri, 23 Sep 2022 15:11:34 +0530 Raju Lakkaraju wrote:
> Subject: [PATCH net V2] net: lan743x: Fixes: 60942c397af6 ("Add support for PTP-IO Event Input External Timestamp (extts)")
>
> Remove PTP_PF_EXTTS support for non-PCI11x1x devices since they do not
> support the PTP-IO Input event triggered timestamping mechanisms
> added
>
> Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
The fixes tag should go before your sign-off. So something like:
Subject: eth: lan743x: reject extts for non-pci11x1x devices
Remove PTP_PF_EXTTS support for non-PCI11x1x devices since they do not
support the PTP-IO Input event triggered timestamping mechanisms
added [...]
Fixes: 60942c397af6 ("Add support for PTP-IO Event Input External Timestamp (extts)")
Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
I'd be good to add to the commit message what the user-visible problem
will be. Crash or just silently accepting a config which won't work?
prev parent reply other threads:[~2022-09-26 20:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 9:41 [PATCH net V2] net: lan743x: Fixes: 60942c397af6 ("Add support for PTP-IO Event Input External Timestamp (extts)") Raju Lakkaraju
2022-09-26 20:04 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220926130429.3ffd78b1@kernel.org \
--to=kuba@kernel.org \
--cc=Ian.Saturley@microchip.com \
--cc=Raju.Lakkaraju@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).