From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E90AC6FA82 for ; Mon, 26 Sep 2022 20:08:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230329AbiIZUIQ (ORCPT ); Mon, 26 Sep 2022 16:08:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230323AbiIZUII (ORCPT ); Mon, 26 Sep 2022 16:08:08 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66C3871985 for ; Mon, 26 Sep 2022 13:08:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 17278B80C75 for ; Mon, 26 Sep 2022 20:08:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C153C433B5; Mon, 26 Sep 2022 20:08:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664222884; bh=TS6vb0m3k6eiRDpO3DmxP8c72gZLLIPpPyJF6ZBcDOw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HIrq1+gKpHusqRrsE9hyu1PR1dOy1+wxTaEs2E5+dbq6BOmQFUpDlcbG8JgCSVRDg wimhH/TAGvhgFnJDSBQ/ekhykin3/uFmjChWMo/FMKh6y2v/iJX3W1rOwIwpwCZsm/ cSdmqhGIpXtRFeXBMslP1EHfqsVmNM9zW0Uy7NE6xAcaGNAW9N5d4PPowOr8l25Lte yKqiFeYDcg6I/YZRu0W9JlwreRRnMYKL+3k3so5GEKNvOuPpa4jwpNiNPpEgcE8OVY RVqLHG/y1Gh/lBU0faB14y/wvV5c/Knuw04fqeZA9yKWXgrinVlQypw7XSlumAj8WW 62E1iAQsPcHpw== Date: Mon, 26 Sep 2022 13:08:03 -0700 From: Jakub Kicinski To: Liu Shixin Cc: Felix Fietkau , John Crispin , Sean Wang , Mark Lee , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger , , , Subject: Re: [PATCH] net: ethernet: mtk_eth_soc: use DEFINE_SHOW_ATTRIBUTE to simplify code Message-ID: <20220926130803.3684471a@kernel.org> In-Reply-To: <20220922142929.3250844-1-liushixin2@huawei.com> References: <20220922142929.3250844-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 22 Sep 2022 22:29:29 +0800 Liu Shixin wrote: > Use DEFINE_SHOW_ATTRIBUTE helper macro to simplify the code. > No functional change. Does not apply cleanly. Please rebase on net-next and put [PATCH net-next v2] in the subject when reposting.