From: Jakub Kicinski <kuba@kernel.org>
To: Yinjun Zhang <yinjun.zhang@corigine.com>
Cc: Simon Horman <simon.horman@corigine.com>,
David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
oss-drivers <oss-drivers@corigine.com>,
Fei Qin <fei.qin@corigine.com>
Subject: Re: [PATCH net-next 2/3] nfp: add support for link auto negotiation
Date: Mon, 26 Sep 2022 18:38:40 -0700 [thread overview]
Message-ID: <20220926183840.12b96ca7@kernel.org> (raw)
In-Reply-To: <20220927011353.GA20766@nj-rack01-04.nji.corigine.com>
On Tue, 27 Sep 2022 09:13:53 +0800 Yinjun Zhang wrote:
> On Mon, Sep 26, 2022 at 09:25:47AM -0700, Jakub Kicinski wrote:
> > On Sat, 24 Sep 2022 10:45:30 +0800 Yinjun Zhang wrote:
> > > Not only check if it's flower, but also check if it's sp_indiff when
> > > it's not flower by parsing the tlv caps.
> >
> > Seems bogus. The speed independence is a property of the whole FW image,
> > you record it in the pf structure.
>
> It's indeed a per-fw property, but we don't have existing way to expose
> per-fw capabilities to driver currently, so use per-vnic tlv caps here.
> Maybe define a new fw symbol is a choice, but my concern is it's not
> visible to netvf driver.
> Any suggestion is welcomed.
Why not put an rtsym with the value in the FW? That'd be my first
go-to way of communicating information about the FW as a whole.
next prev parent reply other threads:[~2022-09-27 1:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 12:12 [PATCH net-next 0/3] nfp: support FEC mode reporting and auto-neg Simon Horman
2022-09-21 12:12 ` [PATCH net-next 1/3] nfp: add support for reporting active FEC mode Simon Horman
2022-09-21 12:12 ` [PATCH net-next 2/3] nfp: add support for link auto negotiation Simon Horman
2022-09-23 1:00 ` Jakub Kicinski
2022-09-23 4:37 ` Yinjun Zhang
2022-09-23 13:21 ` Jakub Kicinski
2022-09-23 15:41 ` Yinjun Zhang
2022-09-24 0:24 ` Jakub Kicinski
2022-09-24 2:45 ` Yinjun Zhang
2022-09-26 16:25 ` Jakub Kicinski
2022-09-27 1:13 ` Yinjun Zhang
2022-09-27 1:38 ` Jakub Kicinski [this message]
2022-09-27 1:52 ` Yinjun Zhang
2022-09-21 12:12 ` [PATCH net-next 3/3] nfp: add support restart of link auto-negotiation Simon Horman
2022-09-23 0:54 ` Jakub Kicinski
2022-09-23 4:40 ` Yinjun Zhang
2022-09-23 4:52 ` Yinjun Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220926183840.12b96ca7@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=fei.qin@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=yinjun.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).