From: Jakub Kicinski <kuba@kernel.org>
To: Christian Langrock <christian.langrock@secunet.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
<herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-ipsec v2] xfrm: replay: Fix ESN wrap around for GSO
Date: Tue, 27 Sep 2022 07:22:49 -0700 [thread overview]
Message-ID: <20220927072249.0e16c09f@kernel.org> (raw)
In-Reply-To: <fe554921-104e-2365-a09b-812a1cedac65@secunet.com>
On Tue, 27 Sep 2022 14:59:50 +0200 Christian Langrock wrote:
> When using GSO it can happen that the wrong seq_hi is used for the last
> packets before the wrap around. This can lead to double usage of a
> sequence number. To avoid this, we should serialize this last GSO
> packet.
Does not build but please wait for reviews before reposting:
net/xfrm/xfrm_replay.c:773:6: error: conflicting types for ‘xfrm_replay_overflow_check’; have ‘bool(struct xfrm_state *, struct sk_buff *)’ {aka ‘_Bool(struct xfrm_state *, struct sk_buff *)’}
773 | bool xfrm_replay_overflow_check(struct xfrm_state *x, struct sk_buff *skb)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
next prev parent reply other threads:[~2022-09-27 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 12:59 [PATCH net-ipsec v2] xfrm: replay: Fix ESN wrap around for GSO Christian Langrock
2022-09-27 14:22 ` Jakub Kicinski [this message]
2022-09-28 6:18 ` Leon Romanovsky
2022-09-28 6:49 ` Steffen Klassert
2022-09-28 21:28 ` kernel test robot
2022-09-28 21:29 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-09-27 12:03 Christian Langrock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220927072249.0e16c09f@kernel.org \
--to=kuba@kernel.org \
--cc=christian.langrock@secunet.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).