From: Jakub Kicinski <kuba@kernel.org>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Bo Liu <liubo03@inspur.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ptp: Remove usage of the deprecated ida_simple_xxx API
Date: Tue, 27 Sep 2022 11:32:42 -0700 [thread overview]
Message-ID: <20220927113242.0349e2a8@kernel.org> (raw)
In-Reply-To: <YzMRM0jwh+fauIWz@hoboy.vegasvil.org>
On Tue, 27 Sep 2022 08:05:23 -0700 Richard Cochran wrote:
> On Tue, Sep 27, 2022 at 08:01:28AM -0700, Richard Cochran wrote:
> > On Sun, Sep 25, 2022 at 09:27:44PM -0400, Bo Liu wrote:
> > > Use ida_alloc_xxx()/ida_free() instead of
> > > ida_simple_get()/ida_simple_remove().
> > > The latter is deprecated and more verbose.
> >
> > I can't say that I am excited about this. It seems like a way to
> > create a regression. I don't see any need to change. After all,
> > there are many "deprecated" interfaces in use.
>
> /git/linux$ git grep ida_simple_get | wc -l
> 119
>
> ~/git/linux$ git grep ida_simple_remove | wc -l
> 169
>
> Please go take care of the other 100+ users of this API first, then
> come bother me again.
It's clearly marked as deprecated and the old API is literally
a define to the new one:
/*
* ida_simple_get() and ida_simple_remove() are deprecated. Use
* ida_alloc() and ida_free() instead respectively.
*/
#define ida_simple_get(ida, start, end, gfp) \
ida_alloc_range(ida, start, (end) - 1, gfp)
#define ida_simple_remove(ida, id) ida_free(ida, id)
This transition is happening sooner or later. Do you have an objection
here or just don't want to review this? I can double check the ASM is
identical after applying...
next prev parent reply other threads:[~2022-09-27 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 1:27 [PATCH] ptp: Remove usage of the deprecated ida_simple_xxx API Bo Liu
2022-09-27 15:01 ` Richard Cochran
2022-09-27 15:05 ` Richard Cochran
2022-09-27 18:32 ` Jakub Kicinski [this message]
2022-09-28 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220927113242.0349e2a8@kernel.org \
--to=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liubo03@inspur.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).