From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Vladimir Oltean <olteanv@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
Rui Sousa <rui.sousa@nxp.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Michael Walle <michael@walle.cc>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Maxim Kochetkov <fido_max@inbox.ru>,
Colin Foster <colin.foster@in-advantage.com>,
Richie Pearn <richard.pearn@nxp.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Gerhard Engleder <gerhard@engleder-embedded.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 net-next 01/12] net/sched: taprio: allow user input of per-tc max SDU
Date: Tue, 27 Sep 2022 14:32:25 -0700 [thread overview]
Message-ID: <20220927143225.546ba2b8@kernel.org> (raw)
In-Reply-To: <20220927212319.pc75hlhsw7s6es6p@skbuf>
On Tue, 27 Sep 2022 21:23:19 +0000 Vladimir Oltean wrote:
> On Tue, Sep 27, 2022 at 11:27:10AM -0700, Jakub Kicinski wrote:
> > I know, that's what I expected you'd say :(
> > You'd need a reverse parser which is a PITA to do unless you have
> > clearly specified bindings.
>
> I think you're underestimating the problem, it's worse than PITA. My A
> still hurts and yet I couldn't find any way in which reverse parsing the
> bad netlink attribute is in any way practical in iproute2, other than
> doing it to prove a point that it's possible.
Yup, iproute2 does not have policy tables, so it's hard.
Once you have tables like this:
https://github.com/kuba-moo/ynl/blob/main/tools/net/ynl/generated/ethtool-user.c#L22
all linking up the types, it's fairly easy to reverse parse:
https://github.com/kuba-moo/ynl/blob/main/tools/net/ynl/lib/ynl.c#L75
Admittedly I haven't added parsing of the bounds yet so it'd just say
"invalid argument .bla.something" not "argument out of range
.bla.something (is: X, range N-M)" but that's just typing.
> > I'd rather you kept the code as is than make precedent for adding both
> > string and machine readable. If we do that people will try to stay on
> > the safe side and always add both.
> >
> > The machine readable format is carries all the information you need.
>
> Nope, the question "What range?" still isn't answered via the machine
> readable format. Just "What integer?".
Hm, doesn't NLMSGERR_ATTR_POLICY contain the bounds?
> > It's just the user space is not clever enough to read it which is,
> > well, solvable.
>
> You should come work at NXP, we love people who keep a healthy dose of
> unnecessary complexity in things :)
Ha! :D
> Sometimes, "not clever enough" is just fine.
Yup, go ahead with just the strings. "We'll get there" for the machine
readable parsing, hopefully, once my YAML descriptions come...
next prev parent reply other threads:[~2022-09-27 21:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 16:32 [PATCH v2 net-next 00/12] Add tc-taprio support for queueMaxSDU Vladimir Oltean
2022-09-23 16:32 ` [PATCH v2 net-next 01/12] net/sched: taprio: allow user input of per-tc max SDU Vladimir Oltean
2022-09-26 20:38 ` Jakub Kicinski
2022-09-27 15:09 ` Vladimir Oltean
2022-09-27 18:27 ` Jakub Kicinski
2022-09-27 21:23 ` Vladimir Oltean
2022-09-27 21:32 ` Jakub Kicinski [this message]
2022-09-23 16:33 ` [PATCH v2 net-next 02/12] tsnep: deny tc-taprio changes to " Vladimir Oltean
2022-09-26 20:40 ` Jakub Kicinski
2022-09-26 21:50 ` Vladimir Oltean
2022-09-26 23:29 ` Jakub Kicinski
2022-09-27 0:22 ` Vladimir Oltean
2022-09-27 0:43 ` Jakub Kicinski
2022-09-23 16:33 ` [PATCH v2 net-next 03/12] igc: " Vladimir Oltean
2022-09-23 16:33 ` [PATCH v2 net-next 04/12] net: stmmac: " Vladimir Oltean
2022-09-23 16:33 ` [PATCH v2 net-next 05/12] net: am65-cpsw: " Vladimir Oltean
2022-09-23 16:33 ` [PATCH v2 net-next 06/12] net: lan966x: " Vladimir Oltean
2022-09-23 16:33 ` [PATCH v2 net-next 07/12] net: dsa: sja1105: " Vladimir Oltean
2022-09-23 16:33 ` [PATCH v2 net-next 08/12] net: dsa: felix: offload per-tc max SDU from tc-taprio Vladimir Oltean
2022-09-23 16:33 ` [PATCH v2 net-next 09/12] net: dsa: hellcreek: Offload " Vladimir Oltean
2022-09-23 16:33 ` [PATCH v2 net-next 10/12] net: enetc: cache accesses to &priv->si->hw Vladimir Oltean
2022-09-23 16:33 ` [PATCH v2 net-next 11/12] net: enetc: use common naming scheme for PTGCR and PTGCAPR registers Vladimir Oltean
2022-09-23 16:33 ` [PATCH v2 net-next 12/12] net: enetc: offload per-tc max SDU from tc-taprio Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220927143225.546ba2b8@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=claudiu.manoil@nxp.com \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=fido_max@inbox.ru \
--cc=gerhard@engleder-embedded.com \
--cc=horatiu.vultur@microchip.com \
--cc=jesse.brandeburg@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=joabreu@synopsys.com \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=richard.pearn@nxp.com \
--cc=rui.sousa@nxp.com \
--cc=vinicius.gomes@intel.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).