From: Jakub Kicinski <kuba@kernel.org>
To: Duoming Zhou <duoming@zju.edu.cn>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
isdn@linux-pingi.de
Subject: Re: [PATCH V3] mISDN: fix use-after-free bugs in l1oip timer handlers
Date: Tue, 27 Sep 2022 17:26:18 -0700 [thread overview]
Message-ID: <20220927172618.58f238d6@kernel.org> (raw)
In-Reply-To: <20220924021842.71754-1-duoming@zju.edu.cn>
On Sat, 24 Sep 2022 10:18:42 +0800 Duoming Zhou wrote:
> + del_timer_sync(&hc->keep_tl);
> + del_timer_sync(&hc->timeout_tl);
> + cancel_work_sync(&hc->workq);
> + del_timer_sync(&hc->keep_tl);
> cancel_work_sync(&hc->workq);
Why not add a bit which will indicate that the device is shutting
down and check it in places which schedule the timer?
I think that's much easier to reason about and we won't need to do
this rep cancel procedure.
next prev parent reply other threads:[~2022-09-28 0:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-24 2:18 [PATCH V3] mISDN: fix use-after-free bugs in l1oip timer handlers Duoming Zhou
2022-09-28 0:26 ` Jakub Kicinski [this message]
2022-09-28 13:27 ` duoming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220927172618.58f238d6@kernel.org \
--to=kuba@kernel.org \
--cc=duoming@zju.edu.cn \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).