From: Jakub Kicinski <kuba@kernel.org>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, Johannes Berg <johannes@sipsolutions.net>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Florian Westphal <fw@strlen.de>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Florent Fourcot <florent.fourcot@wifirst.fr>,
Guillaume Nault <gnault@redhat.com>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
Hangbin Liu <liuhangbin@gmail.com>
Subject: Re: [PATCH net-next] docs: netlink: clarify the historical baggage of Netlink flags
Date: Wed, 28 Sep 2022 07:21:55 -0700 [thread overview]
Message-ID: <20220928072155.600569db@kernel.org> (raw)
In-Reply-To: <a3dbb76a-5ee8-5445-26f1-c805a81c4b22@blackwall.org>
On Wed, 28 Sep 2022 10:03:07 +0300 Nikolay Aleksandrov wrote:
> The part about NLM_F_BULK is correct now, but won't be soon. I have patches to add
> bulk delete to mdbs as well, and IIRC there were plans for other object types.
> I can update the doc once they are applied, but IMO it will be more useful to explain
> why they are used instead of who's using them, i.e. the BULK was added to support
> flush for FDBs w/ filtering initially and it's a flag so others can re-use it
> (my first attempt targeted only FDBs[1], but after a discussion it became clear that
> it will be more beneficial if other object types can re-use it so moved to a flag).
> The first version of the fdb flush support used only netlink attributes to do the
> flush via setlink, later moved to a specific RTM command (RTM_FLUSHNEIGH)[2] and
> finally settled on the flag[3][4] so everyone can use it.
I thought that's all FDB-ish stuff. Not really looking forward to the
use of flags spreading but within rtnl it may make some sense. We can
just update the docs tho, no?
BTW how would you define the exact semantics of NLM_F_BULK vs it not
being set, in abstract terms?
next prev parent reply other threads:[~2022-09-28 14:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 21:23 [PATCH net-next] docs: netlink: clarify the historical baggage of Netlink flags Jakub Kicinski
2022-09-28 7:03 ` Nikolay Aleksandrov
2022-09-28 14:21 ` Jakub Kicinski [this message]
2022-09-28 14:40 ` Nikolay Aleksandrov
2022-09-28 14:43 ` Nikolay Aleksandrov
2022-09-30 11:07 ` Jamal Hadi Salim
2022-09-30 11:29 ` Nikolay Aleksandrov
2022-09-30 14:24 ` Jamal Hadi Salim
2022-09-30 14:34 ` Nikolay Aleksandrov
2022-09-30 16:36 ` Jamal Hadi Salim
2022-09-30 18:19 ` Nikolay Aleksandrov
2022-10-02 13:59 ` Jamal Hadi Salim
2022-09-28 8:04 ` Florent Fourcot
2022-09-28 8:55 ` Nicolas Dichtel
2022-09-28 9:21 ` Nikolay Aleksandrov
2022-09-28 14:37 ` Jakub Kicinski
2022-09-28 14:46 ` Nikolay Aleksandrov
2022-09-28 15:15 ` Jakub Kicinski
2022-09-28 15:19 ` Nicolas Dichtel
2022-09-30 2:21 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220928072155.600569db@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florent.fourcot@wifirst.fr \
--cc=fw@strlen.de \
--cc=gnault@redhat.com \
--cc=jacob.e.keller@intel.com \
--cc=jhs@mojatatu.com \
--cc=johannes@sipsolutions.net \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).