From: Jakub Kicinski <kuba@kernel.org>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: nicolas.dichtel@6wind.com,
Florent Fourcot <florent.fourcot@wifirst.fr>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, Johannes Berg <johannes@sipsolutions.net>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Florian Westphal <fw@strlen.de>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Guillaume Nault <gnault@redhat.com>,
Hangbin Liu <liuhangbin@gmail.com>
Subject: Re: [PATCH net-next] docs: netlink: clarify the historical baggage of Netlink flags
Date: Wed, 28 Sep 2022 08:15:09 -0700 [thread overview]
Message-ID: <20220928081509.2e169f4d@kernel.org> (raw)
In-Reply-To: <60f75b7a-e9c3-ed30-0992-711c7ab23bc1@blackwall.org>
On Wed, 28 Sep 2022 17:46:28 +0300 Nikolay Aleksandrov wrote:
> I like it, can't check right now if we can get into the same issue as with BULK where
> someone is passing unused/wrong flags with the command and we break him though.
So it'd only be effective for new commands, hopefully that's good
enough:
- if (hdr->cmd >= family->resv_start_op && hdr->reserved)
+ if (hdr->cmd >= family->resv_start_op && genl_header_check(nlh, hdr))
the resv_start_op thing I added in this cycle.
> But I'd bite the bullet and maybe issue an extack msg as well.
Fair point, more tests more magic. I'll add a msg.
next prev parent reply other threads:[~2022-09-28 15:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 21:23 [PATCH net-next] docs: netlink: clarify the historical baggage of Netlink flags Jakub Kicinski
2022-09-28 7:03 ` Nikolay Aleksandrov
2022-09-28 14:21 ` Jakub Kicinski
2022-09-28 14:40 ` Nikolay Aleksandrov
2022-09-28 14:43 ` Nikolay Aleksandrov
2022-09-30 11:07 ` Jamal Hadi Salim
2022-09-30 11:29 ` Nikolay Aleksandrov
2022-09-30 14:24 ` Jamal Hadi Salim
2022-09-30 14:34 ` Nikolay Aleksandrov
2022-09-30 16:36 ` Jamal Hadi Salim
2022-09-30 18:19 ` Nikolay Aleksandrov
2022-10-02 13:59 ` Jamal Hadi Salim
2022-09-28 8:04 ` Florent Fourcot
2022-09-28 8:55 ` Nicolas Dichtel
2022-09-28 9:21 ` Nikolay Aleksandrov
2022-09-28 14:37 ` Jakub Kicinski
2022-09-28 14:46 ` Nikolay Aleksandrov
2022-09-28 15:15 ` Jakub Kicinski [this message]
2022-09-28 15:19 ` Nicolas Dichtel
2022-09-30 2:21 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220928081509.2e169f4d@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florent.fourcot@wifirst.fr \
--cc=fw@strlen.de \
--cc=gnault@redhat.com \
--cc=jacob.e.keller@intel.com \
--cc=jhs@mojatatu.com \
--cc=johannes@sipsolutions.net \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).