From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9999EC32771 for ; Thu, 29 Sep 2022 01:15:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231419AbiI2BPJ (ORCPT ); Wed, 28 Sep 2022 21:15:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231303AbiI2BPI (ORCPT ); Wed, 28 Sep 2022 21:15:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91DEE17586 for ; Wed, 28 Sep 2022 18:15:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 08F6061787 for ; Thu, 29 Sep 2022 01:15:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30600C433D6; Thu, 29 Sep 2022 01:15:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664414105; bh=xEouCU4tMbXzuAYIYQFgY1b4c71BsMcFAMZN6c+Z6TE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sZlrYUOxZN5pIwxfwFT52SIpNYULi28s288oCZkQcn3VjIkssTZ/gTd/bUE2JCD5j rAuih92kqYY/Cx8C192ZzcjKQXBcIA/ffUJ1YZwKy5swvh8B5gr9kyHcpEKcwG14NN Jf1OCgc7Kco2Eb2L733TLsJfTwvzTJ6fOalytuYXOoaTwL4/EYV41CpM9k+EgmBsmy YgJ3hIXl36JpNF1yfhsIJZ3togxHg0tiViiPM+j59yeXfROkOA58YSy6ipuImEPblE 6s/G6c9spf/vYsIW2ZZM5+1+1FCrYC2YRWIjEyUYHIo4F+h4JiEnisNcqM4340yiCA T8nR0bwV3YqNg== Date: Wed, 28 Sep 2022 18:15:04 -0700 From: Jakub Kicinski To: Edward Cree Cc: netdev@vger.kernel.org, linux-net-drivers@amd.com, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, habetsm.xilinx@gmail.com Subject: Re: [PATCH v2 net-next 3/6] sfc: optional logging of TC offload errors Message-ID: <20220928181504.234644e3@kernel.org> In-Reply-To: References: <20220928104426.1edd2fa2@kernel.org> <20220928113253.1823c7e1@kernel.org> <20220928120754.5671c0d7@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 28 Sep 2022 22:14:37 +0100 Edward Cree wrote: > On 28/09/2022 20:07, Jakub Kicinski wrote: > > Let's solve practical problems first :) The cases with multiple devices > > offloading are rare AFAIK. > > I know of someone who is working on such a use-case for the Alveo U25N > and running into Interesting difficulties with the same rule getting > offloaded twice; they probably would care about getting both devices' > error messages. I know the plural of anecdote is not data; but I > think it's not so rare that we can completely ignore it. Hm. I wonder if throwing a tracepoint into the extack setting machinery would be a reasonable stop gap for debugging.