From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: linux-mediatek@lists.infradead.org, netdev@vger.kernel.org,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Sujuan Chen" <sujuan.chen@mediatek.com>,
"Bo Jiao" <Bo.Jiao@mediatek.com>, "Felix Fietkau" <nbd@nbd.name>,
"John Crispin" <john@phrozen.org>,
"Sean Wang" <sean.wang@mediatek.com>,
"Mark Lee" <Mark-MC.Lee@mediatek.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Chen Minqiang" <ptpt52@gmail.com>,
"Thomas Hühn" <thomas.huehn@hs-nordhausen.de>
Subject: Re: [PATCH] net: ethernet: mtk_eth_soc: fix state in __mtk_foe_entry_clear
Date: Wed, 28 Sep 2022 19:09:39 -0700 [thread overview]
Message-ID: <20220928190939.3c43516f@kernel.org> (raw)
In-Reply-To: <YzOie0dkiQ43EPnu@makrotopia.org>
On Wed, 28 Sep 2022 02:25:15 +0100 Daniel Golle wrote:
> Setting ib1 state to MTK_FOE_STATE_UNBIND in __mtk_foe_entry_clear
> routine as done by commit 0e80707d94e4c8 ("net: ethernet: mtk_eth_soc:
> fix typo in __mtk_foe_entry_clear") breaks flow offloading, at least
> on older MTK_NETSYS_V1 SoCs; OpenWrt users have confirmed the bug on
> MT7622 and MT7621 systems.
> Felix Fietkau suggested to use MTK_FOE_STATE_INVALID instead which
> works well on both, MTK_NETSYS_V1 and MTK_NETSYS_V2.
>
> Tested on MT7622 (Linksys E8450) and MT7986 (BananaPi BPI-R3).
>
> Suggested-by: Felix Fietkau <nbd@nbd.name>
> Fixes: 0e80707d94e4c8 ("net: ethernet: mtk_eth_soc: fix typo in __mtk_foe_entry_clear")
> Fixes: 33fc42de33278 ("net: ethernet: mtk_eth_soc: support creating mac address based offload entries")
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Looks like this patch is generated on top of net-next while it fixes
a bug in net (judging by mention of 0e80707d94e4c8).
Please rebase on top of net and resent, we'll deal with the conflict.
next prev parent reply other threads:[~2022-09-29 2:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 1:25 [PATCH] net: ethernet: mtk_eth_soc: fix state in __mtk_foe_entry_clear Daniel Golle
2022-09-28 9:27 ` Lorenzo Bianconi
2022-09-29 2:09 ` Jakub Kicinski [this message]
2022-09-30 0:56 ` [PATCH v2] " Daniel Golle
2022-10-01 2:20 ` patchwork-bot+netdevbpf
2022-10-03 12:59 ` [PATCH v2] net: ethernet: mtk_eth_soc: fix state in __mtk_foe_entry_clear: manual merge Matthieu Baerts
2022-10-03 13:47 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220928190939.3c43516f@kernel.org \
--to=kuba@kernel.org \
--cc=Bo.Jiao@mediatek.com \
--cc=Mark-MC.Lee@mediatek.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john@phrozen.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ptpt52@gmail.com \
--cc=sean.wang@mediatek.com \
--cc=sujuan.chen@mediatek.com \
--cc=thomas.huehn@hs-nordhausen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).