From: Guillaume Nault <gnault@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, Florent Fourcot <florent.fourcot@wifirst.fr>,
Nikolay Aleksandrov <razor@blackwall.org>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
Johannes Berg <johannes@sipsolutions.net>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Florian Westphal <fw@strlen.de>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Hangbin Liu <liuhangbin@gmail.com>
Subject: Re: [PATCH net] genetlink: reject use of nlmsg_flags for new commands
Date: Thu, 29 Sep 2022 11:20:55 +0200 [thread overview]
Message-ID: <20220929092055.GA3651@localhost.localdomain> (raw)
In-Reply-To: <20220928183515.1063481-1-kuba@kernel.org>
On Wed, Sep 28, 2022 at 11:35:15AM -0700, Jakub Kicinski wrote:
> Commit 9c5d03d36251 ("genetlink: start to validate reserved header bytes")
> introduced extra validation for genetlink headers. We had to gate it
> to only apply to new commands, to maintain bug-wards compatibility.
> Use this opportunity (before the new checks make it to Linus's tree)
> to add more conditions.
>
> Validate that Generic Netlink families do not use nlmsg_flags outside
> of the well-understood set.
Reviewed-by: Guillaume Nault <gnault@redhat.com>
next prev parent reply other threads:[~2022-09-29 9:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 18:35 [PATCH net] genetlink: reject use of nlmsg_flags for new commands Jakub Kicinski
2022-09-28 19:20 ` Johannes Berg
2022-09-28 21:17 ` Nikolay Aleksandrov
2022-09-28 21:26 ` Nicolas Dichtel
2022-09-29 1:48 ` Jakub Kicinski
2022-09-29 9:20 ` Guillaume Nault [this message]
2022-09-29 17:22 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929092055.GA3651@localhost.localdomain \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florent.fourcot@wifirst.fr \
--cc=fw@strlen.de \
--cc=jacob.e.keller@intel.com \
--cc=jhs@mojatatu.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).