From: Guillaume Nault <gnault@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, robh@kernel.org, johannes@sipsolutions.net,
ecree.xilinx@gmail.com, stephen@networkplumber.org,
sdf@google.com, f.fainelli@gmail.com, fw@strlen.de,
linux-doc@vger.kernel.org, razor@blackwall.org,
nicolas.dichtel@6wind.com
Subject: Re: [PATCH net-next 1/6] docs: add more netlink docs (incl. spec docs)
Date: Thu, 29 Sep 2022 15:34:13 +0200 [thread overview]
Message-ID: <20220929133413.GA6761@localhost.localdomain> (raw)
In-Reply-To: <20220929011122.1139374-2-kuba@kernel.org>
On Wed, Sep 28, 2022 at 06:11:17PM -0700, Jakub Kicinski wrote:
> +Answer requests
> +---------------
> +
> +Older families do not reply to all of the commands, especially NEW / ADD
> +commands. User only gets information whether the operation succeeded or
> +not via the ACK. Try to find useful data to return. Once the command is
> +added whether it replies with a full message or only an ACK is uAPI and
> +cannot be changed. It's better to err on the side of replying.
> +
> +Specifically NEW and ADD commands should reply with information identifying
> +the created object such as the allocated object's ID.
> +
> +Having to rely on ``NLM_F_ECHO`` is a hack, not a valid design.
> +
> +NLM_F_ECHO
> +----------
> +
> +Make sure to pass the request info to genl_notify() to allow ``NLM_F_ECHO``
> +to take effect.
Do you mean that netlink commands should properly handle NLM_F_ECHO,
although they should also design their API so that users don't need it?
next prev parent reply other threads:[~2022-09-29 13:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 1:11 [PATCH net-next 0/6] Netlink protocol specs Jakub Kicinski
2022-09-29 1:11 ` [PATCH net-next 1/6] docs: add more netlink docs (incl. spec docs) Jakub Kicinski
2022-09-29 8:15 ` Bagas Sanjaya
2022-09-29 9:43 ` Nicolas Dichtel
2022-09-29 13:34 ` Guillaume Nault [this message]
2022-09-29 14:32 ` Jakub Kicinski
2022-09-29 15:11 ` Guillaume Nault
2022-09-29 15:47 ` Jakub Kicinski
2022-09-29 15:52 ` Guillaume Nault
2022-09-29 1:11 ` [PATCH net-next 2/6] netlink: add schemas for YAML specs Jakub Kicinski
2022-09-29 1:11 ` [PATCH net-next 3/6] net: add basic C code generators for Netlink Jakub Kicinski
2022-09-29 1:11 ` [PATCH net-next 4/6] netlink: add a proto specification for FOU Jakub Kicinski
2022-09-29 9:02 ` Nicolas Dichtel
2022-09-29 9:06 ` Nicolas Dichtel
2022-09-29 14:41 ` Jakub Kicinski
2022-09-29 1:11 ` [PATCH net-next 5/6] net: fou: regenerate the uAPI from the spec Jakub Kicinski
2022-09-29 1:11 ` [PATCH net-next 6/6] net: fou: use policy and operation tables generated " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929133413.GA6761@localhost.localdomain \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=fw@strlen.de \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=robh@kernel.org \
--cc=sdf@google.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).